config(inline-completion): change supplemental context configuration to always use repomap #6205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will-ShaoHua
changed the title
Will-ShaoHua
changed the title
Will-ShaoHua
commented
Dec 10, 2024
packages/core/src/codewhisperer/util/supplementalContext/crossFileContextUtil.ts
Show resolved
Hide resolved
Will-ShaoHua
commented
Dec 11, 2024
| assert.strictEqual(actual.supplementalContextItems[3].content.split('\n').length, 50) | ||
| }) | ||
|
|
||
| it('for t2 group, should return global bm25 context and no repomap', async function () { |
Contributor
Author
There was a problem hiding this comment.
skipping because we don't have t2 group now as we set all users to be t1 group.
Contributor
Author
There was a problem hiding this comment.
will remove not needed tests later once the experiment is fully done
justinmk3
approved these changes
Dec 11, 2024
Contributor
justinmk3
left a comment
justinmk3
left a comment
There was a problem hiding this comment.
Is this approved for the upcoming release?
jpinkney-aws
approved these changes
Dec 12, 2024
Contributor
Author
@justinmk3 yea, it's requested by the team to ship out with Dec 17th release, but I will double check and get explicit approval for all PRs then turn the PR back to ready state |
leigaol
approved these changes
Dec 13, 2024
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
…to always use repomap (aws#6205) ## Problem Remove client side A/B experiment (control, treatment1, treatment2), move it to service side and always assume treatment1 ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Remove client side A/B experiment (control, treatment1, treatment2), move it to service side and always assume treatment1
Solution
feature/xbranches will not be squash-merged at release time.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.