Skip to content

config(inline-completion): change supplemental context configuration to always use repomap #6205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Will-ShaoHua merged 4 commits into from
Dec 13, 2024
Merged

config(inline-completion): change supplemental context configuration to always use repomap #6205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77d9704
change supplemental context configuration to be always repomap
Will-ShaoHua Dec 10, 2024
5fd9d05
disable test case for treatment group2
Will-ShaoHua Dec 10, 2024
8ba8d06
revert
Will-ShaoHua Dec 11, 2024
0d18cd0
Merge remote-tracking branch 'upstream/master' into all-repomap
Will-ShaoHua Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/amazonq/test/unit/codewhisperer/util/crossFileContextUtil.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ describe('crossFileContextUtil', function () {
assert.strictEqual(actual.supplementalContextItems[3].content.split('\n').length, 50)
})

it('for t2 group, should return global bm25 context and no repomap', async function () {
Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipping because we don't have t2 group now as we set all users to be t1 group.

Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove not needed tests later once the experiment is fully done

it.skip('for t2 group, should return global bm25 context and no repomap', async function () {
await toTextEditor(aStringWithLineCount(200), 'CrossFile.java', tempFolder, { preview: false })
const myCurrentEditor = await toTextEditor('', 'TargetFile.java', tempFolder, {
preview: false,
Expand Down
8 changes: 1 addition & 7 deletions packages/core/src/codewhisperer/util/supplementalContext/crossFileContextUtil.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,14 +284,8 @@ function getSupplementalContextConfig(languageId: vscode.TextDocument['languageI

const group = FeatureConfigProvider.instance.getProjectContextGroup()
switch (group) {
case 'control':
return 'opentabs'

case 't1':
default:
return 'codemap'

case 't2':
return 'bm25'
}
}

Expand Down
Loading