Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "Amazon Q can update mvn and gradle build files"
}
4 changes: 3 additions & 1 deletion packages/core/src/shared/filetypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ export const codefileExtensions = new Set([
'.cljs',
'.cls',
'.cmake',
'.cmd',
'.cob',
'.cobra',
'.coffee',
Expand Down Expand Up @@ -274,6 +275,7 @@ export const codefileExtensions = new Set([
'.pp',
'.pro',
'.prolog',
'.properties',
'.ps1',
'.psd1',
'.psm1',
Expand Down Expand Up @@ -351,7 +353,7 @@ export const codefileExtensions = new Set([
])

// Code file names without an extension
export const codefileNames = new Set(['Dockerfile', 'Dockerfile.build'])
export const codefileNames = new Set(['Dockerfile', 'Dockerfile.build', 'gradlew', 'mvnw'])

/** Returns true if `filename` is a code file. */
export function isCodeFile(filename: string): boolean {
Expand Down
25 changes: 25 additions & 0 deletions packages/core/src/test/shared/filetypes.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import * as workspaceUtils from '../../shared/utilities/workspaceUtils'
import { toArrayAsync } from '../../shared/utilities/collectionUtils'
import { waitUntil } from '../../shared/utilities/timeoutUtils'
import { mapMetadata } from '../../shared/telemetry/telemetryLogger'
import { isCodeFile } from '../../shared/filetypes'

async function getMetrics(n: number, metricName: string, timeout = 1000) {
return await waitUntil(
Expand Down Expand Up @@ -148,3 +149,27 @@ describe('file_editAwsFile telemetry', function () {
// assert.strictEqual(r?.length, 1, 'emitted file_editAwsFile too many times')
})
})

describe('isCodeFile', () => {
it('returns true for code files', function () {
const codeFiles = [
'test.py',
'test.js',
'Dockerfile',
'gradlew',
'mvnw',
'build.gradle',
'gradle/wrapper/gradle-wrapper.properties',
]
for (const codeFilePath of codeFiles) {
assert.strictEqual(isCodeFile(codeFilePath), true)
}
})

it('returns false for other files', function () {
const codeFiles = ['compiled.exe', 'random_file']
for (const filePath of codeFiles) {
assert.strictEqual(isCodeFile(filePath), false)
}
})
})
Loading