Skip to content

build(os-compatibility): normalize file paths and enforce eol consistency #6353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinmk3 merged 2 commits into from
Jan 15, 2025
Merged

build(os-compatibility): normalize file paths and enforce eol consistency #6353

justinmk3 merged 2 commits into from
Jan 15, 2025

Conversation

@muaydin
Copy link
Contributor

@muaydin muaydin commented Jan 13, 2025

Problem

  • Tests were failing or behaving inconsistently on different operating systems due to improper file path normalization.
  • End-of-line (EOL) conflicts were causing unnecessary formatting diffs in collaborative workflows.

Solution

  • Updated the testFile variable in the test runner to normalize paths by replacing backslashes () with forward slashes, ensuring cross-platform compatibility.
  • Added the Prettier rule 'prettier/prettier': ['error', { endOfLine: 'auto' }] to align EOL behavior with the host environment, avoiding platform-specific conflicts.
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@muaydin muaydin requested a review from a team as a code owner January 13, 2025 23:38
@muaydin muaydin closed this Jan 13, 2025
@muaydin muaydin reopened this Jan 13, 2025
@muaydin muaydin closed this Jan 14, 2025
@muaydin muaydin reopened this Jan 14, 2025
@github-actions
Copy link

github-actions bot commented Jan 14, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@jpinkney-aws
Copy link
Contributor

jpinkney-aws commented Jan 14, 2025

/runIntegrationTests

@muaydin
Copy link
Contributor Author

muaydin commented Jan 14, 2025

Looking into failing checks

@justinmk3 justinmk3 changed the title fix(os-compatibility): normalize file paths and enforce eol consistency build(os-compatibility): normalize file paths and enforce eol consistency Jan 14, 2025
justinmk3
justinmk3 reviewed Jan 14, 2025
View reviewed changes
@justinmk3
Copy link
Contributor

justinmk3 commented Jan 14, 2025

/retrybuild

@justinmk3 justinmk3 merged commit 63fafe3 into aws:master Jan 15, 2025
29 of 34 checks passed
avi-alpert pushed a commit to avi-alpert/aws-toolkit-vscode that referenced this pull request Jan 15, 2025
@muaydin @avi-alpert
build: normalize filepath slashes, eol consistency aws#6353
068758f 
## Problem
- Tests were failing or behaving inconsistently on different operating
systems due to improper file path normalization.
- End-of-line (EOL) conflicts were causing unnecessary formatting diffs
in collaborative workflows.

## Solution
- Updated the testFile variable in the test runner to normalize paths by
replacing backslashes (\) with forward slashes, ensuring cross-platform
compatibility.
- Added the Prettier rule 'prettier/prettier': ['error', { endOfLine:
'auto' }] to align EOL behavior with the host environment, avoiding
platform-specific conflicts.
karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
@muaydin @karanA-aws
build: normalize filepath slashes, eol consistency aws#6353
ba205b9 
## Problem
- Tests were failing or behaving inconsistently on different operating
systems due to improper file path normalization.
- End-of-line (EOL) conflicts were causing unnecessary formatting diffs
in collaborative workflows.

## Solution
- Updated the testFile variable in the test runner to normalize paths by
replacing backslashes (\) with forward slashes, ensuring cross-platform
compatibility.
- Added the Prettier rule 'prettier/prettier': ['error', { endOfLine:
'auto' }] to align EOL behavior with the host environment, avoiding
platform-specific conflicts.
kevluu-aws pushed a commit to kevluu-aws/aws-toolkit-vscode that referenced this pull request Jan 23, 2025
@muaydin @kevluu-aws
build: normalize filepath slashes, eol consistency aws#6353
4641201 
## Problem
- Tests were failing or behaving inconsistently on different operating
systems due to improper file path normalization.
- End-of-line (EOL) conflicts were causing unnecessary formatting diffs
in collaborative workflows.

## Solution
- Updated the testFile variable in the test runner to normalize paths by
replacing backslashes (\) with forward slashes, ensuring cross-platform
compatibility.
- Added the Prettier rule 'prettier/prettier': ['error', { endOfLine:
'auto' }] to align EOL behavior with the host environment, avoiding
platform-specific conflicts.
s7ab059789 pushed a commit to s7ab059789/aws-toolkit-vscode that referenced this pull request Feb 19, 2025
@muaydin @s7ab059789
build: normalize filepath slashes, eol consistency aws#6353
4de8669 
## Problem
- Tests were failing or behaving inconsistently on different operating
systems due to improper file path normalization.
- End-of-line (EOL) conflicts were causing unnecessary formatting diffs
in collaborative workflows.

## Solution
- Updated the testFile variable in the test runner to normalize paths by
replacing backslashes (\) with forward slashes, ensuring cross-platform
compatibility.
- Added the Prettier rule 'prettier/prettier': ['error', { endOfLine:
'auto' }] to align EOL behavior with the host environment, avoiding
platform-specific conflicts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@justinmk3 justinmk3 justinmk3 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@muaydin @jpinkney-aws @justinmk3