revert: cloud9 related code #6376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayemaxi
commented
Jan 15, 2025
| These keys are currently set by the core/ package, but many of them may eventually be migrated to | ||
| toolkit/ or amazonq/ if appropriate. | ||
|
|
||
| - `isCloud9`: This is hardcoded by Cloud9 itself, not the Toolkit. |
Contributor
Author
There was a problem hiding this comment.
package.json updates will be a separate PR
hayemaxi
changed the title
hayemaxi
added a commit
to hayemaxi/aws-toolkit-vscode
that referenced
this pull request
Jan 15, 2025
Depends on aws#6376
jpinkney-aws
approved these changes
Jan 16, 2025
justinmk3
reviewed
Jan 16, 2025
packages/amazonq/package.json
Outdated
| "id": "aws.amazonq.notifications", | ||
| "name": "%AWS.notifications.title%", | ||
| "when": "!isCloud9 && !aws.isSageMaker && aws.amazonq.notifications.show" | ||
| "when": "!aws.isSageMaker && aws.amazonq.notifications.show" |
Contributor
There was a problem hiding this comment.
Anything that applies to sagemaker potentially applies to isCloud9CodeEditor. This looks like such a case.
for now, we can either leave this as isCloud9 and create a backlog issue to revisit the remaining isCloud9 cases like this, or rename it to isCloud9CodeEditor (or whatever we call it)
Contributor
Author
There was a problem hiding this comment.
These seem to be leftover artifacts from notifications development. I have fixed them, but left isCloud9 to revisit later.
justinmk3
reviewed
Jan 16, 2025
| const editCreds = messages.editCredentials(false) | ||
| // TODO: getHelp page for Cloud9. | ||
| const buttons = isCloud9() ? [editCreds] : [editCreds, getHelp] | ||
| const buttons = [editCreds, getHelp] |
Contributor
There was a problem hiding this comment.
seems like something we should either leave or leave a todo comment with a token that we can find later. because we don't want to show vscode-related messaging.
Contributor
Author
There was a problem hiding this comment.
The related link is not vscode related: https://docs.aws.amazon.com/signin/latest/userguide/differences-aws_builder_id.html
The auth story for a Cloud9CodeEditor is unclear though. A todo to verify would be better.
justinmk3
reviewed
Jan 16, 2025
|
|
||
| // Only used in rare cases on C9 | ||
| export const reauth = Commands.declare( | ||
| '_aws.codecatalyst.reauthenticate', |
Contributor
There was a problem hiding this comment.
can we delete the command code?
Contributor
Author
There was a problem hiding this comment.
No because the comment was wrong, it's used here:
justinmk3
reviewed
Jan 16, 2025
| } | ||
| } | ||
|
|
||
| // TODO: Delete? as it was only used in Cloud9 |
Contributor
There was a problem hiding this comment.
yeah, we dropped the "quickstart" concept, which had overlap with (1) the marketplace readme, and (2) the new notifications / whats-new concept.
justinmk3
reviewed
Jan 16, 2025
| /** | ||
| * Temporary util while Cloud9 does not have codicon support | ||
| */ | ||
| export function addCodiconToString(codiconName: string, text: string): string { |
Contributor
There was a problem hiding this comment.
might be able to drop this function, maybe a comment that mentions "cloud9" should stay on it
justinmk3
reviewed
Jan 16, 2025
packages/toolkit/.changes/next-release/Removal-3ef48be0-d3f3-4252-be69-9a0684406944.json
Outdated
Show resolved
Hide resolved
justinmk3
approved these changes
Jan 16, 2025
Will-ShaoHua
approved these changes
Jan 16, 2025
hayemaxi
force-pushed
the
cloud9
branch
6 times, most recently
from
11df401 to
2f5215a
Compare
This code removes nearly all cloud9 codepaths: - Icons, readme generation, scripts - ikp3db lambda/sam debugger support - Cloud9 only codepaths and hacks - Docs and comments mentioning Cloud9 Includes some follow up items as TODOs in code. Some items were left in case they are helpful in the future (e.g. for vscode web or similar). The items should be renamed from Cloud9 if used again in the future. Some examples are Cloud9 runtime environment checks (for lambda/sam), `isCloud9()` and properties/text for Cloud9 IDE, some SAM artifacts, don't start LSP server, etc. Search cloud9 in vscode after merging this change.
…252-be69-9a0684406944.json Co-authored-by: Justin M. Keyes <[email protected]>
kevluu-aws
pushed a commit
to kevluu-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 23, 2025
This code removes nearly all cloud9 codepaths: - Icons, readme generation, scripts - ikp3db lambda/sam debugger support - Cloud9 only codepaths and hacks - Docs and comments mentioning Cloud9 Includes some follow up items as TODOs in code. Some items were left in case they are helpful in the future (e.g. for vscode web or similar). The items should be renamed from Cloud9 if used again in the future. Some examples are Cloud9 runtime environment checks (for lambda/sam), `isCloud9()` and properties/text for Cloud9 IDE, some SAM artifacts, don't start LSP server, etc. Search cloud9 in vscode after merging this change. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Justin M. Keyes <[email protected]>
chungjac
pushed a commit
to chungjac/aws-toolkit-vscode
that referenced
this pull request
Jan 24, 2025
This code removes nearly all cloud9 codepaths: - Icons, readme generation, scripts - ikp3db lambda/sam debugger support - Cloud9 only codepaths and hacks - Docs and comments mentioning Cloud9 Includes some follow up items as TODOs in code. Some items were left in case they are helpful in the future (e.g. for vscode web or similar). The items should be renamed from Cloud9 if used again in the future. Some examples are Cloud9 runtime environment checks (for lambda/sam), `isCloud9()` and properties/text for Cloud9 IDE, some SAM artifacts, don't start LSP server, etc. Search cloud9 in vscode after merging this change. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Justin M. Keyes <[email protected]>
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
This code removes nearly all cloud9 codepaths: - Icons, readme generation, scripts - ikp3db lambda/sam debugger support - Cloud9 only codepaths and hacks - Docs and comments mentioning Cloud9 Includes some follow up items as TODOs in code. Some items were left in case they are helpful in the future (e.g. for vscode web or similar). The items should be renamed from Cloud9 if used again in the future. Some examples are Cloud9 runtime environment checks (for lambda/sam), `isCloud9()` and properties/text for Cloud9 IDE, some SAM artifacts, don't start LSP server, etc. Search cloud9 in vscode after merging this change. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Justin M. Keyes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code removes nearly all cloud9 codepaths:
Includes some follow up items as TODOs in code.
Some items were left in case they are helpful in the future (e.g. for vscode web or similar). The items should be renamed from Cloud9 if used again in the future. Some examples are Cloud9 runtime environment checks (for lambda/sam),
isCloud9()and properties/text for Cloud9 IDE, some SAM artifacts, don't start LSP server, etc. Search cloud9 in vscode after merging this change.feature/xbranches will not be squash-merged at release time.