-
Notifications
You must be signed in to change notification settings - Fork 751
revert: cloud9 related code #6376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,6 @@ import * as vscode from 'vscode' | |
| import { Credentials } from '@aws-sdk/types' | ||
| import { authHelpUrl } from '../../shared/constants' | ||
| import globals from '../../shared/extensionGlobals' | ||
| import { isCloud9 } from '../../shared/extensionUtilities' | ||
| import { messages, showMessageWithCancel, showViewLogsMessage } from '../../shared/utilities/messages' | ||
| import { Timeout, waitTimeout } from '../../shared/utilities/timeoutUtils' | ||
| import { fromExtensionManifest } from '../../shared/settings' | ||
|
|
@@ -37,8 +36,8 @@ export function asEnvironmentVariables(credentials: Credentials): NodeJS.Process | |
| export function showLoginFailedMessage(credentialsId: string, errMsg: string): void { | ||
| const getHelp = localize('AWS.generic.message.getHelp', 'Get Help...') | ||
| const editCreds = messages.editCredentials(false) | ||
| // TODO: getHelp page for Cloud9. | ||
| const buttons = isCloud9() ? [editCreds] : [editCreds, getHelp] | ||
| // TODO: Any work towards web/another cloud9 -esqe IDE may need different getHelp docs: | ||
| const buttons = [editCreds, getHelp] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. seems like something we should either leave or leave a todo comment with a token that we can find later. because we don't want to show vscode-related messaging.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The related link is not vscode related: https://docs.aws.amazon.com/signin/latest/userguide/differences-aws_builder_id.html The auth story for a Cloud9CodeEditor is unclear though. A todo to verify would be better. |
||
|
|
||
| void showViewLogsMessage( | ||
| localize('AWS.message.credentials.invalid', 'Credentials "{0}" failed to connect: {1}', credentialsId, errMsg), | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package.json updates will be a separate PR