fix(amazonq): setMaven correctly #6384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dhasani23
commented
Jan 16, 2025
| await setMaven() | ||
| const versionInfo = await getVersionData() | ||
| const mavenVersionInfoMessage = `${versionInfo[0]} (${transformByQState.getMavenName()})` | ||
| telemetry.record({ buildSystemVersion: mavenVersionInfoMessage }) |
Contributor
Author
There was a problem hiding this comment.
This was always recording [undefined, undefined] since the user hasn't selected a project to transform at this point. Plus, we already emit this in the totalRunTime metric at the very end of a transformation anyway.
dhasani23
commented
Jan 16, 2025
| } | ||
|
|
||
| export async function prepareProjectDependencies(dependenciesFolder: FolderInfo, rootPomPath: string) { | ||
| await setMaven() |
Contributor
Author
There was a problem hiding this comment.
Better to set the Maven to use (mvn, mvnw, mvnw.cmd) just before the local build happens to ensure we're using the correct Maven executable.
added 3 commits
January 16, 2025 14:29
ntarakad-aws
approved these changes
Jan 17, 2025
justinmk3
reviewed
Jan 17, 2025
| }) | ||
| } | ||
| transformByQState.setPolledJobStatus(status) | ||
| getLogger().info(`CodeTransformation: polled job status = ${status}`) |
Contributor
There was a problem hiding this comment.
FYI: getLogger() now has a "topic" feature so you can do this at the top of the module:
const logger = getLogger('CodeTransformation')
then logger.info() will prepend the topic name.
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
## Problem `setMaven` is being executed unnecessarily. ## Solution Move the call to happen just before the local build starts.
kevluu-aws
pushed a commit
to kevluu-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 23, 2025
## Problem `setMaven` is being executed unnecessarily. ## Solution Move the call to happen just before the local build starts.
chungjac
pushed a commit
to chungjac/aws-toolkit-vscode
that referenced
this pull request
Jan 24, 2025
## Problem `setMaven` is being executed unnecessarily. ## Solution Move the call to happen just before the local build starts.
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem `setMaven` is being executed unnecessarily. ## Solution Move the call to happen just before the local build starts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
setMavenis being executed unnecessarily.Solution
Move the call to happen just before the local build starts.
feature/xbranches will not be squash-merged at release time.