test(flaky): skip all performance tests. #6459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/runIntegrationTests |
Contributor
|
I wonder if we should just start skipping these since they're generating so much flakiness? Maybe we can re-visit them when they're in flare and gets a much more accurate number |
Contributor
Author
|
Yeah, I think thats likely for the best. It doesn't seem to matter how hight the thresholds are set, it somehow always breaks it. |
Hweinstock
changed the title
|
jpinkney-aws
approved these changes
Jan 29, 2025
This was referenced Jan 31, 2025
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem aws#6117 aws#6457 These issues keep popping up, regardless of the the thresholds. The performance tests are causing more problems then they are solving. Real performance regressions would be captured in telemetry. ## Solution skip all performance tests, revisit once there is less flakiness. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#6117
#6457
These issues keep popping up, regardless of the the thresholds. The performance tests are causing more problems then they are solving. Real performance regressions would be captured in telemetry.
Solution
skip all performance tests, revisit once there is less flakiness.
feature/xbranches will not be squash-merged at release time.