Skip to content

test(flaky): skip all performance tests. #6459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hweinstock merged 4 commits into from
Jan 31, 2025
Merged

test(flaky): skip all performance tests. #6459

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
649c037
test: bump threshold
Hweinstock Jan 29, 2025
08656d7
test: bump other threshold
Hweinstock Jan 29, 2025
dd7687e
Merge branch 'master' into perf/flaky
Hweinstock Jan 29, 2025
6c811fd
test: skip all performance tests
Hweinstock Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/src/shared/performance/performance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ export function performanceTest<TSetup, TExecute>(
const testOption = options[process.platform as 'linux' | 'darwin' | 'win32']

const totalTestRuns = options.testRuns ?? 10

return describe(`${name} performance tests`, () => {
// TODO: unskip this once flakiness is reduced.
return describe.skip(`${name} performance tests`, () => {
let performanceTracker: PerformanceTracker | undefined
const testRunMetrics: PerformanceMetrics[] = []

Expand Down
Loading