-
Notifications
You must be signed in to change notification settings - Fork 749
test(amazonq): skip valid language tests #6497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/runintegrationTests |
KevinDing1
pushed a commit
to KevinDing1/aws-toolkit-vscode
that referenced
this pull request
Feb 6, 2025
## Problem - valid language tests are flaky, specifically the "before each" hook is failing in the CI for valid language ## Solution - skip valid language tests for now These changes will be helpful for when we come back to this issue: - use closeAllEditors function in existing testUtils file - retries for setting up and opening text file
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem - valid language tests are flaky, specifically the "before each" hook is failing in the CI for valid language ## Solution - skip valid language tests for now These changes will be helpful for when we come back to this issue: - use closeAllEditors function in existing testUtils file - retries for setting up and opening text file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
These changes will be helpful for when we come back to this issue:
feature/xbranches will not be squash-merged at release time.