Skip to content

test(amazonq): skip valid language tests #6497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 5, 2025
Merged

test(amazonq): skip valid language tests #6497

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
76b167f
add waitUntil in beforeEach for valid languages
chungjac Feb 4, 2025
c814261
waitUntil for showTextDocument
chungjac Feb 4, 2025
82c7ce4
await
chungjac Feb 4, 2025
c214053
waitUntil for setupTestDocument
chungjac Feb 4, 2025
c94bee2
remove waitUntil and switch test order
chungjac Feb 4, 2025
d7fbba1
additional temp test
chungjac Feb 4, 2025
826a72e
remove closing editor in afterEach
chungjac Feb 4, 2025
9f805f8
remove extra test
chungjac Feb 4, 2025
329aa9b
waitUntil
chungjac Feb 5, 2025
b34d381
increase interval for waituntil
chungjac Feb 5, 2025
2ebdf52
close editor
chungjac Feb 5, 2025
9c12bb8
remove closeAllEditors
chungjac Feb 5, 2025
6f99ed7
await closeAllEditors()
chungjac Feb 5, 2025
f7bcc80
comment out java example
chungjac Feb 5, 2025
f5a63b2
skip valid language tests
chungjac Feb 5, 2025
d68b047
use util function closeAllEditors
chungjac Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions packages/amazonq/test/e2e/amazonq/testGen.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { qTestingFramework } from './framework/framework'
import sinon from 'sinon'
import { Messenger } from './framework/messenger'
import { FollowUpTypes } from 'aws-core-vscode/amazonq'
import { registerAuthHook, using, TestFolder } from 'aws-core-vscode/test'
import { registerAuthHook, using, TestFolder, closeAllEditors } from 'aws-core-vscode/test'
import { loginToIdC } from './utils/setup'
import { waitUntil, workspaceUtils } from 'aws-core-vscode/shared'

Expand Down Expand Up @@ -51,10 +51,12 @@ describe('Amazon Q Test Generation', function () {
assert.fail(`Failed to open ${language} file`)
}

await vscode.window.showTextDocument(document, { preview: false })
await waitUntil(async () => {
await vscode.window.showTextDocument(document, { preview: false })
}, {})

const activeEditor = vscode.window.activeTextEditor
if (!activeEditor || activeEditor.document !== document) {
if (!activeEditor || activeEditor.document.uri.fsPath !== document.uri.fsPath) {
assert.fail(`Failed to make temp file active`)
}
}
Expand All @@ -80,7 +82,7 @@ describe('Amazon Q Test Generation', function () {

afterEach(async () => {
// Close all editors to prevent conflicts with subsequent tests trying to open the same file
await vscode.commands.executeCommand('workbench.action.closeAllEditors')
await closeAllEditors()
framework.removeTab(tab.tabID)
framework.dispose()
sinon.restore()
Expand Down Expand Up @@ -161,9 +163,11 @@ describe('Amazon Q Test Generation', function () {
})

for (const { language, filePath } of testFiles) {
describe(`${language} file`, () => {
// skipping for now since this test is flaky. passes locally, but only half the time in CI
// have tried retries for setupTestDocument, openTextDocument, and showTextDocument
describe.skip(`${language} file`, () => {
beforeEach(async () => {
await setupTestDocument(filePath, language)
await waitUntil(async () => await setupTestDocument(filePath, language), {})

tab.addChatMessage({ command: '/test' })
await tab.waitForChatFinishesLoading()
Expand Down
Loading