-
Notifications
You must be signed in to change notification settings - Fork 749
fix(amazonq): filter out frequent client error from codegeneration telemetry #6521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zchenzhao
approved these changes
Feb 6, 2025
packages/core/src/amazonqFeatureDev/controllers/chat/controller.ts
Outdated
Show resolved
Hide resolved
packages/core/src/amazonqFeatureDev/controllers/chat/controller.ts
Outdated
Show resolved
Hide resolved
jpinkney-aws
reviewed
Feb 7, 2025
packages/core/src/amazonqFeatureDev/controllers/chat/controller.ts
Outdated
Show resolved
Hide resolved
packages/amazonq/.changes/next-release/Bug Fix-85069edd-e299-43e4-b8b8-d1bfa7b635e0.json
Outdated
Show resolved
Hide resolved
packages/core/src/test/amazonqFeatureDev/controllers/chat/controller.test.ts
Outdated
Show resolved
Hide resolved
packages/core/src/test/amazonqFeatureDev/controllers/chat/controller.test.ts
Outdated
Show resolved
Hide resolved
packages/core/src/test/amazonqFeatureDev/controllers/chat/controller.test.ts
Outdated
Show resolved
Hide resolved
39e919b to
51d65e1
Compare
packages/core/src/amazonqFeatureDev/controllers/chat/controller.ts
Outdated
Show resolved
Hide resolved
026e6a7 to
ebc1448
Compare
jpinkney-aws
approved these changes
Feb 10, 2025
|
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
…lemetry (aws#6521) ## Problem We are mistakenly counting several client-side failures as service faults, which is affecting our availability metrics. ## Solution Exclude frequent client errors from faults, they should be errors. there are multiple layers of errors, some of those are categorized to toolkit level errors, for example this part: ``` case MonthlyConversationLimitError.name: case CodeIterationLimitError.name: case PromptRefusalException.name: case NoChangeRequiredException.name: ``` Others are defaulting to ToolkitError with messages. Ideally we should add more error models to toolkit, but for now to make a quick fix, I just looked into the error msg, similar to what we do here: https://github.com/aws/aws-toolkit-vscode/blob/02d21a2fafc7479fb398ea078aa3e3adf7c62e7a/packages/core/src/amazonqFeatureDev/client/featureDev.ts#L198 --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Yuxin Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are mistakenly counting several client-side failures as service faults, which is affecting our availability metrics.
Solution
Exclude frequent client errors from faults, they should be errors.
there are multiple layers of errors, some of those are categorized to toolkit level errors, for example this part:
Others are defaulting to ToolkitError with messages.
Ideally we should add more error models to toolkit, but for now to make a quick fix, I just looked into the error msg, similar to what we do here:
aws-toolkit-vscode/packages/core/src/amazonqFeatureDev/client/featureDev.ts
Line 198 in 02d21a2
feature/xbranches will not be squash-merged at release time.