Skip to content

Conversation

@jpinkney-aws
Copy link
Contributor

@jpinkney-aws jpinkney-aws commented Feb 7, 2025

Problem

Amazon q currently uses the 2.3.2 version of the language server which doesn't appear to be working

Solution

Update to the 3.x.x series for now

Independently i'm going to follow up with teams to understand how this happened. Had we released this feature to prod amazon q inline would have been completely broken


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpinkney-aws jpinkney-aws requested a review from a team as a code owner February 7, 2025 16:28
@github-actions
Copy link

github-actions bot commented Feb 7, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@jpinkney-aws jpinkney-aws merged commit 91adc3f into aws:feature/amazonqLSP Feb 7, 2025
16 of 17 checks passed
@Hweinstock
Copy link
Contributor

When you say not resolving, which step was failing? Also, has this happened before? Out of scope here, but wondering if its worth investing in a solution that will gracefully handle these errors for us to avoid prod failures. Maybe something simple like bumping the version down temporarily when it can't resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants