Skip to content

Conversation

@zuoyaofu
Copy link
Contributor

Problem

  • Clicking review button in Amazon Q UI panel only opens chat without starting review process, creating unnecessary friction in the user workflow.

Solution

  • Modify review tab open logic to automatically prompt user with review scope selection ("active file" vs "entire project"), matching the exact behaviour of the command /review.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@zuoyaofu zuoyaofu force-pushed the review-ui-bug branch 2 times, most recently from d3973ea to 50d549e Compare February 11, 2025 01:33
@zuoyaofu zuoyaofu marked this pull request as ready for review February 11, 2025 19:18
@zuoyaofu zuoyaofu requested review from a team as code owners February 11, 2025 19:18
Copy link
Contributor

@hayemaxi hayemaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks like it's from tech debt and unrelated to PR. LGTM pending approval from your team

@zuoyaofu zuoyaofu merged commit 8126a56 into aws:master Feb 12, 2025
24 of 26 checks passed
@zuoyaofu zuoyaofu deleted the review-ui-bug branch February 12, 2025 19:51
justinmk3 pushed a commit that referenced this pull request Mar 4, 2025
## Problem
Subsequent reviews (`/review`) were not possible after running a review.

## Solution
- subsequent reviews are now allowed
- Fix were made to not impact the previous bug fix where review causes
two "run code review" chat messages
- Fix were made not to impact previous bug fix to auto-trigger `/review`
from Quick Actions Menu
- Reverts #6550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants