refactor(amazonq): revert pre-fetch next recommendations for inline completion #6567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanliu048
changed the title
andrewyuq
approved these changes
Feb 13, 2025
jpinkney-aws
approved these changes
Feb 13, 2025
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "type": "Removal", | |||
| "description": "Reverted prefetch logic to enable more stable inline completion" | |||
Contributor
There was a problem hiding this comment.
These changes haven't been released right? If so, just remove the old changelog + this one
Contributor
|
Merged past code freeze at the request of Matt Schrage, since the previous commit would cause problems with the latest release |
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
…ompletion (aws#6567) This reverts commit 50c9121. ## Problem In the previous change, we applied prefect to every responses. However, this introduced issues with inline completion, causing it to behave inconsistently and produce unexpected completions in the next response. ## Solution To mitigate this, this PR rolls back the responses prefect change to restore stable inline completion behavior. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 50c9121.
Problem
In the previous change, we applied prefect to every responses. However, this introduced issues with inline completion, causing it to behave inconsistently and produce unexpected completions in the next response.
Solution
To mitigate this, this PR rolls back the responses prefect change to restore stable inline completion behavior.
feature/xbranches will not be squash-merged at release time.