Skip to content

Conversation

@dhasani23
Copy link
Contributor

Problem

View Summary button wasn't working after users accept changes, since we save the summary.md to where their project is locally.

Solution

Update summary file path.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dhasani23 dhasani23 requested review from a team as code owners February 14, 2025 00:19
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

diffModel.clearChanges()
transformByQState.setSummaryFilePath('')
// update summary path to where it is locally after user accepts changes, so that View Summary button works
transformByQState.setSummaryFilePath(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we write a test to verify this functionality works? Or update an e2e test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have this covered here:

transformByQState.setSummaryFilePath(path.join(tmpDir, 'summary.md'))
transformByQState
.getChatMessenger()
?.sendJobFinishedMessage(tab.tabID, CodeWhispererConstants.viewProposedChangesChatMessage)
tab.clickCustomFormButton({
id: 'gumbyViewSummary',
text: 'View summary',
})
await tab.waitForEvent(() => tab.getChatItems().length > 14, {
waitTimeoutInMs: 5000,
waitIntervalInMs: 1000,
})
const viewSummaryChatItem = tab.getChatItems().pop()
assert.strictEqual(viewSummaryChatItem?.body?.includes('view a summary'), true)

@justinmk3 justinmk3 merged commit 6d3670a into aws:master Feb 18, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants