Skip to content

fix(amazonq): fix view summary button #6578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinmk3 merged 1 commit into from
Feb 18, 2025
+8 −1
Merged

fix(amazonq): fix view summary button #6578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/amazonq/.changes/next-release/Bug Fix-eac82ab9-bdab-47c4-834d-600cb1a0b6a2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "/transform: allow View Summary button to work even after accepting diff"
}
5 changes: 4 additions & 1 deletion packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,10 @@ export class ProposedTransformationExplorer {
}

diffModel.clearChanges()
transformByQState.setSummaryFilePath('')
// update summary path to where it is locally after user accepts changes, so that View Summary button works
transformByQState.setSummaryFilePath(
Copy link
Contributor

@jpinkney-aws jpinkney-aws Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we write a test to verify this functionality works? Or update an e2e test?

Copy link
Contributor Author

@dhasani23 dhasani23 Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have this covered here:

aws-toolkit-vscode/packages/amazonq/test/e2e/amazonq/transformByQ.test.ts

Lines 164 to 181 in 6ce9dca

transformByQState.setSummaryFilePath(path.join(tmpDir, 'summary.md'))
transformByQState
.getChatMessenger()
?.sendJobFinishedMessage(tab.tabID, CodeWhispererConstants.viewProposedChangesChatMessage)
tab.clickCustomFormButton({
id: 'gumbyViewSummary',
text: 'View summary',
})
await tab.waitForEvent(() => tab.getChatItems().length > 14, {
waitTimeoutInMs: 5000,
waitIntervalInMs: 1000,
})
const viewSummaryChatItem = tab.getChatItems().pop()
assert.strictEqual(viewSummaryChatItem?.body?.includes('view a summary'), true)

path.join(transformByQState.getProjectPath(), ExportResultArchiveStructure.PathToSummary)
)
transformByQState.setProjectCopyFilePath('')
transformByQState.setResultArchiveFilePath('')
transformDataProvider.refresh()
Expand Down
Loading