Skip to content

Conversation

@ctlai95
Copy link
Contributor

@ctlai95 ctlai95 commented Mar 8, 2025

Problem

Support SAS findings

Solution

  • Enable hover component for brazilPackageConfig languageId
  • Disable generateFix for SAS findings
  • Fixed a bug that caused findings to be duplicated

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented Mar 8, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@ctlai95 ctlai95 marked this pull request as ready for review March 8, 2025 01:01
@ctlai95 ctlai95 requested review from a team as code owners March 8, 2025 01:01
@hayemaxi
Copy link
Contributor

This appears to conflict with the changes in #6767

@ctlai95 ctlai95 merged commit 43b0bd1 into aws:master Mar 17, 2025
25 of 26 checks passed
jpinkney-aws pushed a commit to jpinkney-aws/aws-toolkit-vscode that referenced this pull request Mar 20, 2025
## Problem

Support SAS findings


## Solution

- Enable hover component for `brazilPackageConfig` languageId
- Disable generateFix for SAS findings
- Fixed a bug that caused findings to be duplicated


---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants