Skip to content

Conversation

@zuoyaofu
Copy link
Contributor

@zuoyaofu zuoyaofu commented Mar 11, 2025

Problem

Issues reported in chat sometimes are double the amount of the issues tree.

Screenshot 2025-03-11 at 3 20 44 PM

This will happen when the project open is at the root folder of the computer or when it is in a workshop.

Solution

Detect and do not double count when the project path is already an absolute path.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@zuoyaofu zuoyaofu marked this pull request as ready for review March 11, 2025 22:30
@zuoyaofu zuoyaofu requested review from a team as code owners March 11, 2025 22:30
@hayemaxi
Copy link
Contributor

hayemaxi commented Mar 12, 2025

This appears to conflict with the changes in #6751

@zuoyaofu
Copy link
Contributor Author

zuoyaofu commented Mar 12, 2025

This appears to conflict with the changes in #6751

#6751 changes the file path and breaks out of the loop early when the file is found, but my changes does not modify the file path in anyway or touch any lines where #6751 changes are at. If there is a conflict detected, we could merge one PR first and then fix the second one?

@zuoyaofu
Copy link
Contributor Author

/runIntegrationTests

@hayemaxi hayemaxi merged commit 89b9c4d into aws:master Mar 14, 2025
29 of 32 checks passed
@zuoyaofu zuoyaofu deleted the double-issue branch April 10, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants