Skip to content

Conversation

@jguoamz
Copy link
Contributor

@jguoamz jguoamz commented Mar 29, 2025

Problem

LLM does not always use fsRead to list directory, it sometimes fallback to using bash command which requires an additional permission check and the result will be shown in raw bash style which is also confusing to read.

Solution

Create a dedicated ListDirectory tool, updated FsRead to not support listing directory


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@jguoamz jguoamz marked this pull request as ready for review March 29, 2025 01:28
@jguoamz jguoamz requested review from a team as code owners March 29, 2025 01:28
@mr-lee mr-lee merged commit 22a132d into aws:feature/agentic-chat Mar 29, 2025
22 checks passed
@jguoamz jguoamz deleted the listDirectory branch March 29, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants