Skip to content

fix(chat): When user reject executing command, it should not send messages to LLM #7052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2025
Merged

fix(chat): When user reject executing command, it should not send messages to LLM #7052

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0f0f01
When user reject executing command, loop will be terminated, reject w…
Randall-Jiang Apr 15, 2025
5f64d90
fix(chat): Add Undo clickable button and string change (#7051)
Randall-Jiang Apr 15, 2025
d637201
telemetry(chat): request id and error message in error metric (#7045)
chungjac Apr 15, 2025
8ac0127
enble use input after user reject execute command
Randall-Jiang Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/core/src/codewhispererChat/controllers/chat/controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,13 +928,24 @@ export class ChatController {
case 'reject-shell-command':
case 'reject-tool-use':
await this.rejectShellCommand(message)
await this.processToolUseMessage(message)
if (message.tabID) {
await this.sendCommandRejectMessage(message.tabID)
}
if (message.triggerId) {
ConversationTracker.getInstance().markTriggerCompleted(message.triggerId)
}
break
default:
getLogger().warn(`Unhandled action: ${message.action.id}`)
}
}

private async sendCommandRejectMessage(tabID: string) {
const session = this.sessionStorage.getSession(tabID)
session.setAgenticLoopInProgress(false)
this.messenger.sendDirectiveMessage(tabID, '', 'Command Rejected')
}

private async restoreBackup(message: CustomFormActionMessage) {
const tabID = message.tabID
const toolUseId = message.action.formItemValues?.toolUseId
Expand Down