Skip to content

Conversation

@ashishrp-aws
Copy link
Contributor

Problem

Overtime chat history added to request is exceeding 100 messages limit causing errors.

Solution

  • Limiting history to 100 messages max per request.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashishrp-aws ashishrp-aws requested a review from a team as a code owner April 18, 2025 06:43
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

request.conversationState.history = request.conversationState.currentMessage?.userInputMessage?.userIntent
? []
: this.chatHistoryDb.getMessages(tabID).map((chat) => messageToChatMessage(chat))
: this.chatHistoryDb.getMessages(tabID, maxHistoryMessages).map((chat) => messageToChatMessage(chat))
Copy link
Contributor

@tsmithsz tsmithsz Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might cause invalid history.

We added a limit of 250 based on the API spec here:
https://github.com/aws/aws-toolkit-vscode/blob/feature/agentic-chat/packages/core/src/shared/db/chatDb/chatDb.ts#L28

I think the limit was increased a month ago

@ashishrp-aws ashishrp-aws deleted the feature/agentic-chat-thinking-box branch April 19, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants