Skip to content

fix(chat): fix for history overload issue #7101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(chat): fix for history overload issue #7101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/core/src/codewhispererChat/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ export const defaultContextLengths: ContextLengths = {

export const defaultStreamingResponseTimeoutInMs = 180_000

export const maxHistoryMessages = 100

export const ignoredDirectoriesAndFiles = [
// Dependency directories
'node_modules',
Expand Down
3 changes: 2 additions & 1 deletion packages/core/src/codewhispererChat/controllers/chat/controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ import {
additionalContentInnerContextLimit,
workspaceChunkMaxSize,
defaultContextLengths,
maxHistoryMessages,
} from '../../constants'
import { ChatSession } from '../../clients/chat/v0/chat'
import { amazonQTabSuffix } from '../../../shared/constants'
Expand Down Expand Up @@ -1601,7 +1602,7 @@ export class ChatController {
// Do not include chatHistory for requests going to Mynah
request.conversationState.history = request.conversationState.currentMessage?.userInputMessage?.userIntent
? []
: this.chatHistoryDb.getMessages(tabID).map((chat) => messageToChatMessage(chat))
: this.chatHistoryDb.getMessages(tabID, maxHistoryMessages).map((chat) => messageToChatMessage(chat))
Copy link
Contributor

@tsmithsz tsmithsz Apr 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might cause invalid history.

We added a limit of 250 based on the API spec here:
https://github.com/aws/aws-toolkit-vscode/blob/feature/agentic-chat/packages/core/src/shared/db/chatDb/chatDb.ts#L28

I think the limit was increased a month ago

request.conversationState.conversationId = session.sessionIdentifier

triggerPayload.documentReferences = this.mergeRelevantTextDocuments(triggerPayload.relevantTextDocuments)
Expand Down
Loading