Skip to content

Conversation

@dhasani23
Copy link
Contributor

Problem

/transform was unnecessarily prompting users for their target JDK paths in some cases.

Solution

Remove the prompt.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dhasani23 dhasani23 requested a review from a team as a code owner May 15, 2025 23:38
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@dhasani23
Copy link
Contributor Author

We already have an E2E test which covers prompting user for the user for the JDK path

@dhasani23
Copy link
Contributor Author

dhasani23 commented May 15, 2025

/runIntegrationTests

@dhasani23
Copy link
Contributor Author

/runIntegrationTests

@nkomonen-amazon
Copy link
Contributor

/retryBuilds

@dhasani23 dhasani23 merged commit ea593e2 into aws:master May 16, 2025
33 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants