Skip to content

fix(amazonq): remove target JDK path prompt #7328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
+8 −0
Merged

fix(amazonq): remove target JDK path prompt #7328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bf3351
fix(amazonq): remove target JDK path prompt
May 15, 2025
ab0c2f5
typo
May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/amazonq/.changes/next-release/Bug Fix-636765f1-2278-4a2d-b512-7c63ecc2ce67.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "/transform: avoid prompting user for target JDK path unnecessarily"
}
4 changes: 4 additions & 0 deletions packages/core/src/amazonqGumby/chat/controller/controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,13 +688,17 @@ export class GumbyController {
const pathToJavaHome = extractPath(data.message)
if (pathToJavaHome) {
transformByQState.setSourceJavaHome(pathToJavaHome)
// TO-DO: delete line below and uncomment the block below when releasing CSB
await this.prepareLanguageUpgradeProject(data.tabID)
// if source and target JDK versions are the same, just re-use the source JAVA_HOME and start the build
/*
if (transformByQState.getTargetJDKVersion() === transformByQState.getSourceJDKVersion()) {
transformByQState.setTargetJavaHome(pathToJavaHome)
await this.prepareLanguageUpgradeProject(data.tabID)
} else {
this.promptJavaHome('target', data.tabID)
}
*/
} else {
this.messenger.sendUnrecoverableErrorResponse('invalid-java-home', data.tabID)
}
Expand Down
Loading