config(amazonq): nep only auto trigger on acceptance if there is nextToken #7641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
atonaamz
reviewed
Jul 10, 2025
| languageClient.sendNotification('aws/logInlineCompletionSessionResults', params) | ||
| if (inlineCompletionProvider) { | ||
| // Only auto trigger on acceptance if there is a nextToken | ||
| if (inlineCompletionProvider && session.editsStreakPartialResultToken) { |
Contributor
There was a problem hiding this comment.
Is there any case we return empty nextToken and still want to trigger GenerateCompletions without nextToken?
Contributor
Author
There was a problem hiding this comment.
not a requirement at this point, the requirement is to exhaust cached suggestion on the model side
Contributor
Author
|
/retryBuilds |
floralph
approved these changes
Jul 11, 2025
Contributor
Author
|
/retryBuilds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Token
Problem
Solution
feature/xbranches will not be squash-merged at release time.