Skip to content

config(amazonq): nep only auto trigger on acceptance if there is nextToken #7641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025
Merged

config(amazonq): nep only auto trigger on acceptance if there is nextToken #7641

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7faa3a
config(amazonq): nep only auto trigger on acceptance if there is next…
Will-ShaoHua Jul 10, 2025
4959fe0
Merge remote-tracking branch 'upstream/master' into trigger
Will-ShaoHua Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/amazonq/src/app/inline/EditRendering/displayImage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,8 @@ export async function displaySvgDecoration(
isInlineEdit: true,
}
languageClient.sendNotification('aws/logInlineCompletionSessionResults', params)
if (inlineCompletionProvider) {
// Only auto trigger on acceptance if there is a nextToken
if (inlineCompletionProvider && session.editsStreakPartialResultToken) {
Copy link
Contributor

@atonaamz atonaamz Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any case we return empty nextToken and still want to trigger GenerateCompletions without nextToken?

Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a requirement at this point, the requirement is to exhaust cached suggestion on the model side

await inlineCompletionProvider.provideInlineCompletionItems(
editor.document,
endPosition,
Expand Down
Loading