-
Notifications
You must be signed in to change notification settings - Fork 746
feat(amazonq): Implement backslash abstraction #7694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
laura-codess
wants to merge
20
commits into
aws:feature/ui-e2e-tests
from
laura-codess:implement_backslash
Closed
feat(amazonq): Implement backslash abstraction #7694
laura-codess
wants to merge
20
commits into
aws:feature/ui-e2e-tests
from
laura-codess:implement_backslash
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as webpack.NormalModuleReplacementPlugin that needed to be there in order for the amazonq to compile
…he checks. have to commit to check since the build compiles with no errors
…e tests are done running
…lkit-vscode into feature/ui-e2e-tests
…s to handle mynah overlays
|
Contributor
|
I'm assuming this is dependent on #7685? Could be worth explicitly calling this out in the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Implemented
backslash.test.tswhich is the test suite where all the menu overlay tests will live. In order to implement this test suite, I also added dismissOverlay tocleanupHelper.ts. It is not fully matured yet because I noticed that the menu overlay is being actively changed as of right now.NOTE: This PR depends on #7685
feature/xbranches will not be squash-merged at release time.