Skip to content

Conversation

@BlakeLazarine
Copy link
Contributor

@BlakeLazarine BlakeLazarine commented Jul 17, 2025

Problem

The line comments to ignore a single issue were being ignored by agentic reviewer.

Inconsistent icons for Fix option when hovered over the issue in code editor (comment icon) and issue panel( wrench icon)

Solution

Find and call the function which was being used by /review tool to do ignore logic.

changed the icon to be displayed as wrench in code editor

image
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@BlakeLazarine BlakeLazarine requested review from a team as code owners July 17, 2025 19:26
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@BlakeLazarine BlakeLazarine changed the title Code review tool fix(amazonq): handle suppress single finding, change icon Jul 17, 2025
@BlakeLazarine BlakeLazarine reopened this Jul 17, 2025
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

Copy link
Contributor

@laileni-aws laileni-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laileni-aws
Copy link
Contributor

Please update the PR description according to your changes and provide Screenshots

@BlakeLazarine BlakeLazarine merged commit 3898ca2 into aws:master Jul 17, 2025
35 of 37 checks passed
laileni-aws added a commit to laileni-aws/aws-toolkit-vscode that referenced this pull request Jul 19, 2025
This reverts commit 3898ca2, reversing
changes made to c43ff0f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants