fix(amazonq): fix finding suppression, change icon, change tool name #7731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… keep it consistent in all places
|
BlakeLazarine
changed the title
|
laileni-aws
reviewed
Jul 22, 2025
| modelSelection: true, | ||
| workspaceFilePath: vscode.workspace.workspaceFile?.fsPath, | ||
| qCodeReviewInChat: true, | ||
| codeReviewInChat: false, |
Contributor
There was a problem hiding this comment.
why this is being renamed?
Contributor
There was a problem hiding this comment.
If yes, Did we do necessary changes in Flare?
Sticking to one name is advisable to avoid permutations and combinations in between VSC and Flare
Contributor
Author
There was a problem hiding this comment.
we were told to remove the q term in case q branding changes down the line
Contributor
There was a problem hiding this comment.
Yeah but this is internal code? We dont show this param to CX so its safe to use this!
If not we need to test with all the combinations.
Contributor
Author
There was a problem hiding this comment.
its been tested
Contributor
There was a problem hiding this comment.
Did we test with below scenarios
- Old VSC + New Flare
- New VSC + New Flare
- Old VSC + Old Flare
bywang56
approved these changes
Jul 22, 2025
laileni-aws
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Includes changes from this older PR #7696 which got reverted
Solution
re-do reverted changes
Renames QCodeReview tool to CodeReview
feature/xbranches will not be squash-merged at release time.