Skip to content

fix(amazonq): fix finding suppression, change icon, change tool name #7731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 22, 2025
Merged

fix(amazonq): fix finding suppression, change icon, change tool name #7731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9b51191
fix(amazonq): rename QCodeReview tool to CodeReview
blakelaz-amazon Jul 17, 2025
dfdf377
fix(amazonq): fix issue with casing
blakelaz-amazon Jul 18, 2025
aff7180
Merge branch 'aws:master' into code-review-tool
mkovelam Jul 18, 2025
e62889f
feat(amazonq): enabling code review tool
mkovelam Jul 18, 2025
c5b9976
Merge branch 'aws:master' into code-review-tool
singhAws Jul 19, 2025
990def6
Merge master branch and resolve conflicts
singhAws Jul 20, 2025
e193525
deps: bump @aws-toolkits/telemetry to 1.0.329
singhAws Jul 21, 2025
2770a81
fix(amazonq): handle suppress single finding in agentic reviewer
blakelaz-amazon Jul 21, 2025
06b4df6
fix(amazonq): changed the icon for security issue hover fix option to…
blakelaz-amazon Jul 21, 2025
34a6675
fix(amazonq): disable codeReviewInChat feature flag
blakelaz-amazon Jul 21, 2025
532c37f
Merge branch 'master' into code-review-tool
BlakeLazarine Jul 22, 2025
683e49f
Merge branch 'aws:master' into code-review-tool
singhAws Jul 22, 2025
5211459
Merge branch 'aws:master' into code-review-tool
singhAws Jul 22, 2025
f2699b1
Merge branch 'aws:master' into code-review-tool
singhAws Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"skippedTestReport": "ts-node ./scripts/skippedTestReport.ts ./packages/amazonq/test/e2e/"
},
"devDependencies": {
"@aws-toolkits/telemetry": "^1.0.328",
"@aws-toolkits/telemetry": "^1.0.329",
"@playwright/browser-chromium": "^1.43.1",
"@stylistic/eslint-plugin": "^2.11.0",
"@types/he": "^1.2.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/amazonq/src/lsp/chat/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,7 +710,7 @@ async function handlePartialResult<T extends ChatResult>(
) {
const decryptedMessage = await decryptResponse<T>(partialResult, encryptionKey)

// This is to filter out the message containing findings from qCodeReview tool to update CodeIssues panel
// This is to filter out the message containing findings from CodeReview tool to update CodeIssues panel
decryptedMessage.additionalMessages = decryptedMessage.additionalMessages?.filter(
(message) =>
!(message.messageId !== undefined && message.messageId.endsWith(CodeWhispererConstants.findingsSuffix))
Expand Down
2 changes: 1 addition & 1 deletion packages/amazonq/src/lsp/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ export async function startLanguageServer(
reroute: true,
modelSelection: true,
workspaceFilePath: vscode.workspace.workspaceFile?.fsPath,
qCodeReviewInChat: true,
codeReviewInChat: false,
Copy link
Contributor

@laileni-aws laileni-aws Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is being renamed?

Copy link
Contributor

@laileni-aws laileni-aws Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If yes, Did we do necessary changes in Flare?
Sticking to one name is advisable to avoid permutations and combinations in between VSC and Flare

Copy link
Contributor Author

@BlakeLazarine BlakeLazarine Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we were told to remove the q term in case q branding changes down the line

Copy link
Contributor

@laileni-aws laileni-aws Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but this is internal code? We dont show this param to CX so its safe to use this!

If not we need to test with all the combinations.

Copy link
Contributor Author

@BlakeLazarine BlakeLazarine Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its been tested

Copy link
Contributor

@laileni-aws laileni-aws Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we test with below scenarios

  • Old VSC + New Flare
  • New VSC + New Flare
  • Old VSC + Old Flare

},
window: {
notifications: true,
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/codewhisperer/models/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -907,4 +907,4 @@ export const predictionTrackerDefaultConfig = {
maxSupplementalContext: 15,
}

export const findingsSuffix = '_qCodeReviewFindings'
export const findingsSuffix = '_codeReviewFindings'
Loading