feat(amazonq): Add Pin Context Tests and Update to pinContextHelper #7829
+96
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
looks like we need to rebase the latest changes based on the github actions |
|
feature --> feat |
surajrdy-aws
changed the title
Hweinstock
reviewed
Aug 12, 2025
| export async function getSubMenuItems(webview: WebviewView): Promise<{ items: WebElement[]; labels: string[] }> { | ||
| try { | ||
| const menuList = await waitForElement(webview, By.css('.mynah-detailed-list-items-block')) | ||
| await sleep(3000) |
There was a problem hiding this comment.
Why is this additional sleep needed?
| console.log('Menu item found:', labelText) | ||
| } catch (e) { | ||
| labels.push('') | ||
| console.log('Could not get text for menu item') |
There was a problem hiding this comment.
should we fail here? If we can't find an item in the menu isn't that indicative of a bug?
|
|
||
| return { items: menuListItems, labels } | ||
| } catch (e) { | ||
| console.error('Error getting Pin Context menu items:', e) |
| export async function clickSubMenuItem(webview: WebviewView, itemName: string): Promise<boolean> { | ||
| try { | ||
| const menuList = await waitForElement(webview, By.css('.mynah-detailed-list-items-block')) | ||
| await sleep(3000) |
There was a problem hiding this comment.
Why is this sleep needed? Shouldn't it be covered by waitForElement?
| return true | ||
| } | ||
| } catch (e) { | ||
| continue |
There was a problem hiding this comment.
same question as above about errors.
| console.log(`Pin Context menu item not found: ${itemName}`) | ||
| return false | ||
| } catch (e) { | ||
| console.error(`Error clicking Pin Context menu item ${itemName}:`, e) |
There was a problem hiding this comment.
If this fails I think we should throw instead of returning a boolean.
| await createPrompt.click() | ||
| await clickPinContextButton(webviewView) | ||
| await clickPinContextMenuItem(webviewView, 'Prompts') | ||
| await clickSubMenuItem(webviewView, 'test') |
There was a problem hiding this comment.
my understanding is that this returns a boolean false if it fails, but this won't cause the test to fail.
| await clickPinContextMenuItem(webviewView, '@workspace') | ||
| }) | ||
| it('Prompts Context Test', async () => { |
There was a problem hiding this comment.
same idea before on test labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have yet to implement the initial P0 Pin Context Tests. The pinContextHelper does not mesh well with sub menu items when clicking through different prompts to use.
Solution
I have implemented the File Context and Prompt Context Test. The Pin Context test with the @workspace was previously implemented. I have implemented the helpers: getSubMenuItems and clickSubMenuItem in the pinContextHelper. All tests still run together.
Test Suite:
feature/xbranches will not be squash-merged at release time.