Skip to content

Conversation

@leigaol
Copy link
Contributor

@leigaol leigaol commented Aug 19, 2025

Problem

Bug: When inline suggestion is active but user types a character that does not match the typeahead, this typing event triggered a inline completion API call that eventually did not manage to display suggestion on screen, which eventually reported as rejected completions.

Solution

Previously, before Flare migration, we had this design:

https://github.com/aws/aws-toolkit-vscode/blob/amazonq/v1.74.0/packages/amazonq/src/app/inline/activation.ts#L108

Auto trigger will be disabled if at that moment the suggestion is visible.

Under the previous design, the first character that does not match the typeahead will not make a new auto trigger, it simply rejects the current inline completion.

This PR is to bring back the old design.

It is not customer facing, hence no change log.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested a review from a team as a code owner August 19, 2025 01:06
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@leigaol leigaol merged commit 9f42cb0 into aws:master Aug 19, 2025
31 checks passed
leigaol added a commit to leigaol/aws-toolkit-vscode that referenced this pull request Aug 19, 2025
* chore: merge release candidate version rc-20250815 (aws#7916)

## Problem
This merges the released changes for rc-20250815 into main.
MCM-132479224

## Solution


---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.

---------

Co-authored-by: Lei Gao <[email protected]>
Co-authored-by: Na Yue <[email protected]>
Co-authored-by: Will Lo <[email protected]>
Co-authored-by: Aidan Ton <[email protected]>
Co-authored-by: atontb <[email protected]>

* fix(sagemaker): Reduce number of reconnect retries (aws#7827)

## Problem
When a connection to a remote space is severed, the extension will
attempt to reconnect up to 60 times. Each reconnect attempt opens the
Space Details page in a new browser tab. Opening up to 60 new tabs is a
poor user experience.

## Solution
We change the maximum number of retries to 8.

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.

Co-authored-by: Newton Der <[email protected]>

* fix(amazonq): do not auto trigger if the ongoing typeahead does not match (aws#7924)

## Problem

Bug: When inline suggestion is active but user types a character that
does not match the typeahead, this typing event triggered a inline
completion API call that eventually did not manage to display suggestion
on screen, which eventually reported as rejected completions.






## Solution


Previously, before Flare migration, we had this design:


https://github.com/aws/aws-toolkit-vscode/blob/amazonq/v1.74.0/packages/amazonq/src/app/inline/activation.ts#L108

Auto trigger will be disabled if at that moment the suggestion is
visible.

Under the previous design, the first character that does not match the
typeahead will not make a new auto trigger, it simply rejects the
current inline completion.

This PR is to bring back the old design.

It is not customer facing, hence no change log.


---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.

---------

Co-authored-by: tsmithsz <[email protected]>
Co-authored-by: Na Yue <[email protected]>
Co-authored-by: Will Lo <[email protected]>
Co-authored-by: Aidan Ton <[email protected]>
Co-authored-by: atontb <[email protected]>
Co-authored-by: Newton Der <[email protected]>
Co-authored-by: Newton Der <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants