Skip to content

Conversation

@chungjac
Copy link
Contributor

@chungjac chungjac commented Aug 20, 2025

Problem

  • npm link is not working for some people when connecting local language-server-runtimes

Solution

  • npm pack has been working better for people, hence updating documentation to include the npm pack approach

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chungjac chungjac requested a review from a team as a code owner August 20, 2025 23:20
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@tsmithsz
Copy link
Contributor

Should we add it as an alternate approach instead of replacing? Just in case we want to refer to both methods

@chungjac chungjac merged commit 2f49805 into aws:master Aug 21, 2025
31 checks passed
@chungjac chungjac deleted the doc branch October 8, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants