telemetry: flush usertriggerDecision event on keystroke or manual trigger #8085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
Will-ShaoHua
changed the title
leigaol
approved these changes
Sep 23, 2025
atonaamz
reviewed
Sep 23, 2025
| config: ConfigurationEntry | ||
| ): Promise<void> { | ||
| // Call report user decisions once to report recommendations leftover from last invocation. | ||
| RecommendationHandler.instance.reportUserDecisions(-1) |
Contributor
There was a problem hiding this comment.
what if we already report user decision?
Contributor
Author
There was a problem hiding this comment.
nothing will be sent
Contributor
Author
There was a problem hiding this comment.
it's flushing the staged metrics
atonaamz
approved these changes
Sep 23, 2025
Will-ShaoHua
added a commit
to Will-ShaoHua/aws-toolkit-vscode
that referenced
this pull request
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Problem
previously UTD will be delayed until next service call, which means it doesn't gurantee service team will collect all the datapoints
Solution
feature/xbranches will not be squash-merged at release time.