Skip to content

telemetry: flush usertriggerDecision event on keystroke or manual trigger #8085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

telemetry: flush usertriggerDecision event on keystroke or manual trigger #8085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/core/src/codewhisperer/commands/invokeRecommendation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ export async function invokeRecommendation(
client: DefaultCodeWhispererClient,
config: ConfigurationEntry
) {
// Call report user decisions once to report recommendations leftover from last invocation.
RecommendationHandler.instance.reportUserDecisions(-1)

if (!editor || !config.isManualTriggerEnabled) {
return
}
Expand Down
2 changes: 0 additions & 2 deletions packages/core/src/codewhisperer/service/inlineCompletionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,6 @@ export class InlineCompletionService {
}
}

// Call report user decisions once to report recommendations leftover from last invocation.
RecommendationHandler.instance.reportUserDecisions(-1)
TelemetryHelper.instance.setInvokeSuggestionStartTime()
ClassifierTrigger.instance.recordClassifierResultForAutoTrigger(editor, autoTriggerType, event)

Expand Down
3 changes: 3 additions & 0 deletions packages/core/src/codewhisperer/service/keyStrokeHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ export class KeyStrokeHandler {
client: DefaultCodeWhispererClient,
config: ConfigurationEntry
): Promise<void> {
// Call report user decisions once to report recommendations leftover from last invocation.
RecommendationHandler.instance.reportUserDecisions(-1)
Copy link
Contributor

@atonaamz atonaamz Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we already report user decision?

Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing will be sent

Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's flushing the staged metrics

Copy link
Contributor

@atonaamz atonaamz Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok


try {
if (!config.isAutomatedTriggerEnabled) {
return
Expand Down
Loading