fix(smus): Add status validation for space operations #8160
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
**Description** Added status checks for SageMaker space operations to prevent invalid actions. **fix done** 1. The stopSpace function now validates space status before attempting to stop, showing appropriate warning messages for spaces already in Stopped/Stopping states or currently Starting. 2. Also added status refresh before open remote connect **Testing Done** code debug
PotatoWKY
changed the title
| void vscode.window.showWarningMessage('This space is already in Stopped/Stopping state') | ||
| return | ||
| } else if (node.getStatus() === 'Starting') { | ||
| void vscode.window.showWarningMessage('This space is starting, please stop it later') |
There was a problem hiding this comment.
Can we change the text to be prescriptive? Similar to the actual API message? "Space {spaceName} is in Starting state. Wait until it is Running to attempt stop again." Same for the other one - Let's use the SpaceName instead of "this"
There was a problem hiding this comment.
Yeah that would be better, let me find the spaceName variable and add it.
| node: SagemakerSpaceNode | SagemakerUnifiedStudioSpaceNode, | ||
| ctx: vscode.ExtensionContext, | ||
| sageMakerClient?: SagemakerClient | ||
| ) { |
There was a problem hiding this comment.
Thanks a lot for making the fix! Appreciate it!
| return | ||
| } | ||
|
|
||
| await tryRefreshNode(node) |
There was a problem hiding this comment.
Just to confirm, this would also change the text on the Space node to reflect state after the API call right?
There was a problem hiding this comment.
Yes, the text (Stopped/Running) on the space would also be updated.
4 participants
Description
Added status checks for SageMaker space operations to prevent invalid actions.
Picture: When opening remote connection:
fix done
The stopSpace function now validates space status before attempting to stop, showing appropriate warning messages for spaces already in Stopped/Stopping states or currently Starting.
Also added status refresh before open remote connect
Testing Done
code debug
feature/xbranches will not be squash-merged at release time.