Skip to content

fix(smus): Add status validation for space operations #8160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2025
Merged

fix(smus): Add status validation for space operations #8160

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f37506b
fix(smus): Add status validation for space operations
PotatoWKY Oct 9, 2025
185d106
add spaceName variable in the warning message
PotatoWKY Oct 9, 2025
d9cb44c
Merge branch 'master' into master
PotatoWKY Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/core/src/awsService/sagemaker/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,16 @@ export async function stopSpace(
ctx: vscode.ExtensionContext,
sageMakerClient?: SagemakerClient
) {
Copy link
Contributor

@vpbhargav vpbhargav Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for making the fix! Appreciate it!

await tryRefreshNode(node)
if (node.getStatus() === 'Stopped' || node.getStatus() === 'Stopping') {
void vscode.window.showWarningMessage(`Space ${node.spaceApp.SpaceName} is already in Stopped/Stopping state.`)
return
} else if (node.getStatus() === 'Starting') {
void vscode.window.showWarningMessage(
`Space ${node.spaceApp.SpaceName} is in Starting state. Wait until it is Running to attempt stop again.`
)
return
}
const spaceName = node.spaceApp.SpaceName!
const confirmed = await showConfirmationMessage({
prompt: `You are about to stop this space. Any active resource will also be stopped. Are you sure you want to stop the space?`,
Expand Down Expand Up @@ -179,7 +189,7 @@ export async function openRemoteConnect(
void vscode.window.showErrorMessage(ConnectFromRemoteWorkspaceMessage)
return
}

await tryRefreshNode(node)
Copy link
Contributor

@vpbhargav vpbhargav Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, this would also change the text on the Space node to reflect state after the API call right?

Copy link
Contributor Author

@PotatoWKY PotatoWKY Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the text (Stopped/Running) on the space would also be updated.

if (node.getStatus() === 'Stopped') {
// In case of SMUS, we pass in a SM Client and for SM AI, it creates a new SM Client.
const client = sageMakerClient ? sageMakerClient : new SagemakerClient(node.regionCode)
Expand Down
Loading