add both failure and success update #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sage-maker
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
pintaoz-aws
previously approved these changes
Sep 2, 2025
papriwal
reviewed
Sep 2, 2025
.github/workflows/pr-checks.yml
Outdated
| run: | | ||
| if [[ "${{ github.event.pull_request.user.login }}" == ${{ secrets.SAGEMAKER_BOT_USER_LOGIN }} ]]; then | ||
| echo "Integration test Succeeded. Putting Success Metrics onto Cloudwatch" | ||
| echo "Integration test Succeeded. Putting Success Metrics = 1 and Failure = 0onto Cloudwatch" |
Contributor
There was a problem hiding this comment.
nit: 0onto you probably wanted a space in there
papriwal
previously approved these changes
Sep 2, 2025
sage-maker
dismissed stale reviews from papriwal and pintaoz-aws
via
ae36f3b
sage-maker
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
papriwal
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the UnitTestFailureAlarm not coming out of alarm by updating both sides of failure and success metric on a PR run