Skip to content

add both failure and success update #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sage-maker merged 2 commits into from
Sep 2, 2025
Merged

add both failure and success update #339

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb49f1d
add both failure and success update
sage-maker Sep 2, 2025
ae36f3b
fix a whitespace
sage-maker Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/pr-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,17 +82,19 @@ jobs:
if: ${{ failure() }}
run: |
if [[ "${{ github.event.pull_request.user.login }}" == ${{ secrets.SAGEMAKER_BOT_USER_LOGIN }} ]]; then
echo "Integration test Failed. Putting Failure Metrics onto Cloudwatch"
echo "Integration test Failed. Putting Failure Metrics = 1 and Success = 0 onto Cloudwatch"
aws cloudwatch put-metric-data --metric-name IntegrationTestFailure --namespace SageMakerPySdkCoreMonitoringMetrics --value 1 --unit Count --dimensions MetricCategory=Integration
aws cloudwatch put-metric-data --metric-name IntegrationTestSuccess --namespace SageMakerPySdkCoreMonitoringMetrics --value 0 --unit Count --dimensions MetricCategory=Integration
else
echo "Putting metrics has been skipped"
fi
- name: Put Success Metrics to CloudWatch
if: ${{ success() }}
run: |
if [[ "${{ github.event.pull_request.user.login }}" == ${{ secrets.SAGEMAKER_BOT_USER_LOGIN }} ]]; then
echo "Integration test Succeeded. Putting Success Metrics onto Cloudwatch"
echo "Integration test Succeeded. Putting Success Metrics = 1 and Failure = 0onto Cloudwatch"
Copy link
Contributor

@papriwal papriwal Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 0onto you probably wanted a space in there

aws cloudwatch put-metric-data --metric-name IntegrationTestSuccess --namespace SageMakerPySdkCoreMonitoringMetrics --value 1 --unit Count --dimensions MetricCategory=Integration
aws cloudwatch put-metric-data --metric-name IntegrationTestFailure --namespace SageMakerPySdkCoreMonitoringMetrics --value 0 --unit Count --dimensions MetricCategory=Integration
else
echo "Putting metrics has been skipped"
fi
Expand Down Expand Up @@ -130,17 +132,19 @@ jobs:
if: ${{ failure() }}
run: |
if [[ "${{ github.event.pull_request.user.login }}" == ${{ secrets.SAGEMAKER_BOT_USER_LOGIN }} ]]; then
echo "Unit test run Failed. Putting Failure Metrics onto Cloudwatch"
echo "Unit test run Failed. Putting Failure Metrics = 1 and Success = 0 onto Cloudwatch"
aws cloudwatch put-metric-data --metric-name UnitTestFailure --namespace SageMakerPySdkCoreMonitoringMetrics --value 1 --unit Count --dimensions MetricCategory=Unit-${{ matrix.python-version }}
aws cloudwatch put-metric-data --metric-name UnitTestSuccess --namespace SageMakerPySdkCoreMonitoringMetrics --value 0 --unit Count --dimensions MetricCategory=Unit-${{ matrix.python-version }}
else
echo "Putting metrics has been skipped"
fi
- name: Put Success Metrics
if: ${{ success() }}
run: |
if [[ "${{ github.event.pull_request.user.login }}" == ${{ secrets.SAGEMAKER_BOT_USER_LOGIN }} ]]; then
echo "Unit test run Succeeded. Putting Success Metrics onto Cloudwatch"
echo "Unit test run Succeeded. Putting Success Metrics = 1 and Failure = 0 onto Cloudwatch"
aws cloudwatch put-metric-data --metric-name UnitTestSuccess --namespace SageMakerPySdkCoreMonitoringMetrics --value 1 --unit Count --dimensions MetricCategory=Unit-${{ matrix.python-version }}
aws cloudwatch put-metric-data --metric-name UnitTestFailure --namespace SageMakerPySdkCoreMonitoringMetrics --value 0 --unit Count --dimensions MetricCategory=Unit-${{ matrix.python-version }}
else
echo "Putting metrics has been skipped"
fi
Expand Down