Skip to content

chore: fix semantic versioning for wildcard identifier #5105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 1, 2025
Merged

chore: fix semantic versioning for wildcard identifier #5105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f14cd1
chore: fix semantic versioning for pinned major or minor versions wit…
Narrohag Mar 26, 2025
ac43bbd
add unit test related to versioning fix
Narrohag Mar 26, 2025
b2e4ebe
fix styling
Narrohag Mar 26, 2025
efa33f4
Merge branch 'master' into semantic-versioning
benieric Mar 27, 2025
fd98a09
Merge branch 'master' into semantic-versioning
benieric Mar 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/sagemaker/jumpstart/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,12 @@ def _select_version(
)
return version_str if version_str in available_versions else None

if version_str[-1] == "*":
# major or minor version is pinned, e.g 1.* or 1.0.*
return utils.get_latest_version(
[version for version in available_versions if version.startswith(version_str[:-1])]
)

try:
spec = SpecifierSet(f"=={version_str}")
except InvalidSpecifier:
Expand Down
12 changes: 12 additions & 0 deletions tests/unit/sagemaker/jumpstart/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15990,6 +15990,18 @@
"spec_key": "community_models_specs/tensorflow-ic-"
"imagenet-inception-v3-classification-4/specs_v3.0.0.json",
},
{
"model_id": "meta-textgeneration-llama-2-7b",
"version": "4.9.0",
"min_version": "2.49.0",
"spec_key": "community_models/meta-textgeneration-llama-2-7b/specs_v4.9.0.json",
},
{
"model_id": "meta-textgeneration-llama-2-7b",
"version": "4.13.0",
"min_version": "2.49.0",
"spec_key": "community_models/meta-textgeneration-llama-2-7b/specs_v4.13.0.json",
},
]

BASE_PROPRIETARY_HEADER = {
Expand Down
24 changes: 24 additions & 0 deletions tests/unit/sagemaker/jumpstart/test_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,30 @@ def test_jumpstart_cache_get_header():
semantic_version_str="1.0.*",
)

assert JumpStartModelHeader(
{
"model_id": "meta-textgeneration-llama-2-7b",
"version": "4.13.0",
"min_version": "2.49.0",
"spec_key": "community_models/meta-textgeneration-llama-2-7b/specs_v4.13.0.json",
}
) == cache.get_header(
model_id="meta-textgeneration-llama-2-7b",
semantic_version_str="*",
)

assert JumpStartModelHeader(
{
"model_id": "meta-textgeneration-llama-2-7b",
"version": "4.13.0",
"min_version": "2.49.0",
"spec_key": "community_models/meta-textgeneration-llama-2-7b/specs_v4.13.0.json",
}
) == cache.get_header(
model_id="meta-textgeneration-llama-2-7b",
semantic_version_str="4.*",
)

assert JumpStartModelHeader(
{
"model_id": "ai21-summarization",
Expand Down