node-efa: extend doc for Bottlerocket #939
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ytsssun
force-pushed
the
update-efa-for-bottlerocket
branch
from
0704fd3 to
9096988
Compare
ytsssun
force-pushed
the
update-efa-for-bottlerocket
branch
from
9096988 to
b8498b4
Compare
|
Update the wording based on feedback ^ |
|
This build error "no folder Then this can be rebased and wait for review. |
chrisnegus
left a comment
chrisnegus
left a comment
There was a problem hiding this comment.
Really good work, @ytsssun ! I have a couple of editing suggestions, but otherwise it looks great.
Signed-off-by: Yutong Sun <[email protected]>
ytsssun
force-pushed
the
update-efa-for-bottlerocket
branch
from
b8498b4 to
f7b43e5
Compare
|
Pushed change to address comments ^ |
| ==== | ||
| [#efa-bottlerocket] | ||
| === Using Bottlerocket with EFA | ||
|
|
||
| Bottlerocket AMI version 1.28.0 and later include official support for EFA. To use Bottlerocket for EFA-enabled nodes, specify `amiFamily: Bottlerocket` in your configuration. If you need to use a custom AMI ID, you must use standard `nodeGroups` instead of `managedNodeGroups`. |
There was a problem hiding this comment.
this heading is showing up as a paragraph and not a heading, I suspect we need to do a syntax check pass on this @chrisnegus @tucktuck9
There was a problem hiding this comment.
A blank line is needed before the [#efa-bottlerocket] line for === Using Bottlerocket with EFA to be printed as a heading. I made the suggestion above.
Co-authored-by: Chris Negus <[email protected]>
|
Hi @chrisnegus , any updates on this PR? Is there anything I can help with? |
LGTM. My one comment looks like it was taken care of. |
6 participants
Issue #, if available: N/A
Description of changes:
Extend documentation in
node-efa.adocfor Bottlerocket usage.Also updated the part about EFA device plugin as
eksctltoday also automatically deploys the Device Plugin for nodes that have EFA interfaces enabled.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.