Skip to content

Go: Update all bucket name uses to user input, env vars, or approved names. #6970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

Go: Update all bucket name uses to user input, env vars, or approved names. #6970

merged 1 commit into from
Oct 9, 2024

Conversation

@Laren-AWS
Copy link
Contributor

@Laren-AWS Laren-AWS commented Oct 9, 2024

  • All examples that use buckets ask for user input.
  • All unit tests use the approved fictitious bucket name.
  • All integration tests get the name for the environment or fall back to the approved name (in which case the test will fail as expected).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Laren-AWS Laren-AWS self-assigned this Oct 9, 2024
@github-actions github-actions bot added the Go-v2 This issue relates to the AWS SDK for Go V2 label Oct 9, 2024
@Laren-AWS Laren-AWS added On Call Review needed This work needs an on-call review Task A general update to the code base for language clarification, missing actions, tests, etc. labels Oct 9, 2024
@Laren-AWS Laren-AWS requested review from a team and scmacdon and removed request for a team October 9, 2024 00:06
@DavidSouther DavidSouther added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Oct 9, 2024
@DavidSouther DavidSouther removed the request for review from scmacdon October 9, 2024 12:48
@DavidSouther DavidSouther merged commit 0d05e83 into awsdocs:main Oct 9, 2024
14 checks passed
scmacdon
scmacdon reviewed Oct 9, 2024
View reviewed changes
gov2/cloudfront/CreateDistribution/CreateDistribution.go
func main() {

flag.StringVar(&bucketName, "bucket", "", "<EXAMPLE-BUCKET-NAME>")
flag.StringVar(&bucketName, "bucket", "", "amzn-s3-demo-bucket")
Copy link
Contributor

@scmacdon scmacdon Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks good. Entire PR looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scmacdon scmacdon scmacdon left review comments

@DavidSouther DavidSouther DavidSouther approved these changes

Assignees

@Laren-AWS Laren-AWS

Labels

Go-v2 This issue relates to the AWS SDK for Go V2 On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Laren-AWS @DavidSouther @scmacdon