Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 11, 2022

Bumps node-fetch from 2.6.7 to 3.3.0.

Release notes

Sourced from node-fetch's releases.

v3.3.0

3.3.0 (2022-11-10)

Features

v3.2.10

3.2.10 (2022-07-31)

Bug Fixes

v3.2.9

3.2.9 (2022-07-18)

Bug Fixes

  • Headers: don't forward secure headers on protocol change (#1599) (e87b093)

v3.2.8

3.2.8 (2022-07-12)

Bug Fixes

v3.2.7

3.2.7 (2022-07-11)

Bug Fixes

v3.2.6

3.2.6 (2022-06-09)

Bug Fixes

  • undefined reference to response.body when aborted (#1578) (1c5ed6b)

v3.2.5

3.2.5 (2022-06-01)

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by node-fetch-bot, a new releaser for node-fetch since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 11, 2022
@Apollon77
Copy link
Contributor

node-fetch 3.x is ESM only!! This might be a breakign change, so I would not merge that directly!

options are:

  • adjust code to be able to work with ESM packages (in fact require aka import is async now)
  • alternative is to replace node-fetch by a "multi build version" - https://github.com/esm2cjs/node-fetch This is automatically providing ESM/CJS combi version
  • or stay on 2.x (but without updates)

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/node-fetch-3.3.0 branch from cf5deca to 213168c Compare November 25, 2022 00:45
@ericzon
Copy link
Collaborator

ericzon commented Dec 7, 2022

@Apollon77 trying @esm2cjs/node-fetch with v14.17.6 makes appear the error: Cannot find module 'node:http' .

node: prefix syntax is available from v14.18 and it's appearing here

I solved that issue switching to v16.14.0 but this reduces compatibility...

@Apollon77
Copy link
Contributor

@ericzon Hm .. .Yes then seems that some of the "sidehorus" packages already switched to that as minimum. In fact you can set 14.18 as minimum, but yes that would be breaking a bit. (with having in mind that Node.js 14 goes EOL in April 23 I think it could be considered ok to requuire an "up to date nodejs 14" :-)).

Then only chance is for now to stay with node-fetch 2.x and do not update to 3.x (But this might miss security updates).

So these are the both "meeeehhhh" options ... choose one ;-)

@ericzon
Copy link
Collaborator

ericzon commented Dec 7, 2022

@Apollon77 I think it's reasonable to align library compatibility with EoL of Nodejs versions. Nobody can complain too much about that. By now, we'll switch to @esm2cjs/node-fetch to reduce some security vulnerabilities. We'll update also the requirements in the docs.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/node-fetch-3.3.0 branch from 213168c to 04f4b43 Compare December 8, 2022 02:00
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/node-fetch-3.3.0 branch from 04f4b43 to 64b7483 Compare December 21, 2022 06:55
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/node-fetch-3.3.0 branch from 64b7483 to f7a641c Compare January 12, 2023 04:49
Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.7 to 3.3.0.
- [Release notes](https://github.com/node-fetch/node-fetch/releases)
- [Commits](node-fetch/node-fetch@v2.6.7...v3.3.0)

---
updated-dependencies:
- dependency-name: node-fetch
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/node-fetch-3.3.0 branch from f7a641c to 202298c Compare January 12, 2023 04:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 13, 2023

Superseded by #1291.

@dependabot dependabot bot closed this Mar 13, 2023
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/node-fetch-3.3.0 branch March 13, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants