-
Notifications
You must be signed in to change notification settings - Fork 634
build(deps): bump node-fetch from 2.6.7 to 3.3.0 #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
node-fetch 3.x is ESM only!! This might be a breakign change, so I would not merge that directly! options are:
|
cf5deca to
213168c
Compare
|
@Apollon77 trying @esm2cjs/node-fetch with v14.17.6 makes appear the error: Cannot find module 'node:http' .
I solved that issue switching to v16.14.0 but this reduces compatibility... |
|
@ericzon Hm .. .Yes then seems that some of the "sidehorus" packages already switched to that as minimum. In fact you can set 14.18 as minimum, but yes that would be breaking a bit. (with having in mind that Node.js 14 goes EOL in April 23 I think it could be considered ok to requuire an "up to date nodejs 14" :-)). Then only chance is for now to stay with node-fetch 2.x and do not update to 3.x (But this might miss security updates). So these are the both "meeeehhhh" options ... choose one ;-) |
|
@Apollon77 I think it's reasonable to align library compatibility with EoL of Nodejs versions. Nobody can complain too much about that. By now, we'll switch to @esm2cjs/node-fetch to reduce some security vulnerabilities. We'll update also the requirements in the docs. |
213168c to
04f4b43
Compare
04f4b43 to
64b7483
Compare
64b7483 to
f7a641c
Compare
Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.7 to 3.3.0. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.7...v3.3.0) --- updated-dependencies: - dependency-name: node-fetch dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
f7a641c to
202298c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Superseded by #1291. |








Bumps node-fetch from 2.6.7 to 3.3.0.
Release notes
Sourced from node-fetch's releases.
... (truncated)
Commits
55a4870feat: add static Response.json (#1670)c071406(1138) - Fixed HTTPResponseError with correct constructor and usage (#1666)6f72caadocs: fix missing comma in example (#1623)2880238fix: ReDoS referrer (#1611)e87b093fix(Headers): don't forward secure headers on protocol change (#1599)bcfb71cchore: remove triple-slash directives from typings (#1285) (#1287)95165d5fix spelling (#1602)11b7033fix: possibly flaky test (#1523)4f43c9efix: always warn Request.data (#1550)1c5ed6bfix: undefined reference to response.body when aborted (#1578)Maintainer changes
This version was pushed to npm by node-fetch-bot, a new releaser for node-fetch since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)