DrawNode local properties full supported now, removed all hardcoded clamps; DrawNode cpp-tests switched to ImGUI ;

[aismann]

Describe your changes

DrawNode::properties full_support + all hardcoded clamps removed
_drawTriangles removed (= part of _drawPoly or _drawPolygon)

=> Redesign: "flat Properties members"

• removed all "hardcoded clamps"
• add const to all properties getters
• add missing DrawNode::properties.getScale()
• removed pragma push_macro("TRANSPARENT") section
• cpp-tests DrawNode: switch from ax::ui to ax::extension::ImGUI
• class ax::Label adapt properties: underline/strikethrough

---

• check/adapt axmol\ui (axmol\ui\UIMediaPlayer.cpp:
• check/adapt AX_LABEL_DEBUG_DRAW
• check/adapt AX_SPRITE_DEBUG_DRAW
• check/adapt AX_SPRITEBATCHNODE_DEBUG_DRAW (not implemented)
• check/adapt AX_LABELBMFONT_DEBUG_DRAW
• check/adapt AX_LABELATLAS_DEBUG_DRAW (not implemented)
• check/adapt FairyGUI (extensions\fairygui\src\fairygui\GGraph.cpp)
• check/adapt Spine (extensions\spine\src\spine\SkeletonRenderer.cpp)
• check/adapt templates\cpp\Source\MainScene.cpp
• check/adapt tests\live2d-tests\Source\SampleScene.cpp
• check/adapt cpp-tests:(ActionsTest/BugsTest/ClippingNodeTest/MultiTouchTest/PhysicsTest/RendererTest/SpritePolygonTest/TileMapTest/UIListViewTest)

see also diffs

Issue ticket number and link

Checklist before requesting a review

For each PR

• Add Copyright if it missed:
  - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

• I have performed a self-review of my code.

  Optional:

  • I have checked readme and add important infos to this PR.
  • I have added/adapted some tests too.

For core/new feature PR

• I have checked readme and add important infos to this PR.
• I have added thorough tests.

Axmol 3.x ------------------------------------------------------------

For each 3.x PR

• Check the '#include "axmol.h"' and replace it with the needed headers.

[aismann]

@w1257 please give feedback too (= optional reviewer)

[aismann]

Adapt Label.cpp underline/strikethrough thickness:

[w1257]

For the future PR(s), I suggest moving some of the sliders to the ImGUI inspector.

[aismann]

For the future PR(s), I suggest moving some of the sliders to the ImGUI inspector.

Good idea!
But switching between the inspector and the sliders on the scene is strange.
I think about it.

I like the idea, add an own Dialog:

[aismann]

@halx99
can you have a look plz?

[ 40%] Built target plainlua
gmake[1]: *** [CMakeFiles/Makefile2:3637: tests/lua-tests/CMakeFiles/lua-tests.dir/rule] Error 2
gmake: *** [Makefile:879: lua-tests] Error 2
build.ps1: /home/runner/work/axmol/axmol/tools/cmdline/axmol.ps1:89
Line |
  89 |          . $build_script @sub_args
     |          ~~~~~~~~~~~~~~~~~~~~~~~~~
     | Build fail, ret=2
Error: Process completed with exit code 1.

[rh101]

For the future PR(s), I suggest moving some of the sliders to the ImGUI inspector.

Good idea! But switching between the inspector and the sliders on the scene is strange. I think about it.

ImGUI is not implemented for all platforms (such as iOS), so using ImGUI to control aspects of test cases would cause issues if running the cpp-tests project on such platforms.

[aismann]

@halx99
From my point of view, ready for review again.

[halx99]

/clang-format

[axmol-bot]

👋 @halx99 Command /clang-format received. Running code formatting, please wait...

[axmol-bot]

✅ Formatting completed and changes have been committed to the PR branch: DrawNode_properties_full_support_remove_clamps.
@halx99 please refresh to see the latest code.

[aismann]

Approved. Thanks for helping hands

[halx99]

I also fix the duplicated condition check _preserveDrawOrder in drawPoint, please review

[halx99]

/clang-format

[axmol-bot]

👋 @halx99 Command /clang-format received. Running code formatting, please wait...

[axmol-bot]

✅ Formatting completed and changes have been committed to the PR branch: DrawNode_properties_full_support_remove_clamps.
@halx99 please refresh to see the latest code.

[aismann]

I also fix the duplicated condition check _preserveDrawOrder in drawPoint, please review

It looks good on my computer. As always, thank you very much.
I will improve some of the DrawNode tests in a new PR in a few days.

[halx99]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors the DrawNode class by replacing the properties struct with direct member variables for drawing parameters such as thickness scale, local scale, pivot, rotation, position, and draw order. The applyTransform method is renamed to applyLocalTransform, and redundant thickness and radius checks are removed from various drawing functions. The TRANSPARENT macro is replaced with Color(). Test cases in DrawNodeTest are updated to reflect these API changes and integrate with an ImGui-based UI. Review comments identify a memory leak in _drawColoredTriangle due to unmanaged dynamic allocation, an inconsistency in the polygon outline width calculation in _drawPolygon that halves the thickness, and an issue where pointSize is incorrectly used as thickness for polygon outlines in _drawPoints, leading to oversized borders.