fix(Core/Unit): Improve vehicle exit safety checks and fallback logic

[sogladev]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

AI-assisted Pull Requests

Important

While the use of AI tools when preparing pull requests is not prohibited, contributors must clearly disclose when such tools have been used and specify the model involved.

Contributors are also expected to fully understand the changes they are submitting and must be able to explain and justify those changes when requested by maintainers.

• AI tools (e.g. ChatGPT, Claude, or similar) were used entirely or partially in preparing this pull request. Please specify which tools were used, if any.

Issues Addressed:

• (Scripts/Mount): Traveler's Tundra Mammoth vendor NPC issues. #15831

fun is, when you're e.g. standing at a slope and exit the vendors or under passengers, you can throw them under the texture and they will drop unter the world.

#15831 (comment)

• [Gundrak] Gal'darah Impale mechanic can drop players out of bounds #24270

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

.go xyz 1919.7325 795.66583 135.66655 604 4.763204

• [Gundrak] Gal'darah Impale mechanic can drop players out of bounds #24270

.go xyz 3320.7324 493.23688 74.50289 615 4.09756

• (Scripts/Mount): Traveler's Tundra Mammoth vendor NPC issues. #15831 (comment)

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Gultask]

I've got vehicles to consistently drop players OOB, but admittedly that's not really hard to do: #24270

[sogladev]

I've got vehicles to consistently drop players OOB, but admittedly that's not really hard to do: #24270

I added a line of sight and floor check to fix seatAddon repositioning to invalid locations. This fixes your Gal'darah Impale issue too

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The LoS check uses Map::isInLineOfSight with raw (x,y,z) from the unit and target position. Unlike WorldObject::IsWithinLOS/IsWithinLOSInMap, this does not account for collision height / hit-sphere points and can produce false negatives (e.g., ray intersecting terrain when both points are near the ground), causing the code to incorrectly fall back to the vehicle's position. Consider using the existing LOS helper on WorldObject/Unit (or at least adding collision-height offsets) for a more reliable check here.

Suggested change

	bool isInLoS = GetMap()->isInLineOfSight(GetPositionX(), GetPositionY(), GetPositionZ(), pos.GetPositionX(), pos.GetPositionY(), pos.GetPositionZ(), GetPhaseMask(), LINEOFSIGHT_ALL_CHECKS, VMAP::ModelIgnoreFlags::Nothing);
	bool isInLoS = IsWithinLOSInMap(pos.GetPositionX(), pos.GetPositionY(), pos.GetPositionZ(), LINEOFSIGHT_ALL_CHECKS, VMAP::ModelIgnoreFlags::Nothing);

[sogladev]

This signature doesn't exist.

[Copilot]

floorZ is computed via vehicleBase->GetMapHeight(...), but GetMapHeight internally offsets the provided Z by the caller object's collision height. Using the vehicle base (often much larger than the passenger) can change which surface is detected under (x,y), and may incorrectly trigger the fallback. Using the passenger (this->GetMapHeight) or calling Map::GetHeight with an explicit Z offset would avoid vehicle-size-dependent results.

Suggested change

	float floorZ = vehicleBase->GetMapHeight(pos.GetPositionX(), pos.GetPositionY(), pos.GetPositionZ());
	float floorZ = GetMapHeight(pos.GetPositionX(), pos.GetPositionY(), pos.GetPositionZ());