Skip to content

add interface for warning, error and report #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 28 commits into
base: change_interface_export_variant
Choose a base branch
from
Draft

add interface for warning, error and report #20

wants to merge 28 commits into from

Conversation

@mamueluth
Copy link
Member

@mamueluth mamueluth commented Jul 26, 2024

  • ddd basic test for error codes setting
  • docs for error and warning signals

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
  2. Give your PR a descriptive title. Add a short summary, if required.
  3. Make sure the pipeline is green.
  4. Don’t be afraid to request reviews from maintainers.
  5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

@mergify
Copy link

mergify bot commented Jul 26, 2024

@mamueluth, all pull requests must be targeted towards the master development branch.
Once merged into master, it is possible to backport to change_interface_export_variant, but it must be in master
to have these changes reflected into new distributions.

@mamueluth mamueluth force-pushed the change_interface_export_variant branch from bb92320 to b6a7819 Compare July 29, 2024 09:25
mamueluth and others added 28 commits July 29, 2024 11:26
@mamueluth
move creation of stateinterfaces to systeminterface
a94d670
@mamueluth
store description in state_interface and provide functions for
c6002b8 
setting/gettting
@mamueluth
return correct name for InterfaceDescription
bb33010
@mamueluth
move parsing of interface description to component parser
d32972c
@mamueluth
adjusted actuator- and sensor_interface as well
bda8f5d
@mamueluth
add first tests
30f9a24
@mamueluth
adjust sensor_interface getting/setting and add tests
bbdc3ca
@mamueluth
add more tests
8189306
@mamueluth
first steps towards variants and storing of value in handle, missing:
64b5c6b 
* variant
* adjusting of resource manager
@mamueluth
add variant support
e36f48b
@mamueluth
adjusted resource manager to work with shared_ptr adapt actuator,sensor
ee81291 
and system
@mamueluth
cleanup
54a86ca
@mamueluth
fix failing tests
c645b37
@mamueluth
change rest of component_interface test and mark what should be removed
bcf9cf2
@mamueluth
code review suggestions and:
7224ef8 
* components check for export of interfaces
* change intefaces to allow custom export and test
@mamueluth
undo prefix_ -> prefix (HWInfo) and Command-/StateIntefaceSharedPtr
c5e7430
@mamueluth
merge parser functions
3f55818
@mamueluth
export_interfaces_2() virtual for custom interface export
d4d423a
@mamueluth
use unordered map and adjust tests
da354d8
@mamueluth
make states and commands of component interfaces private
da326fd
@mamueluth
add migration guide for
c5001ea
@mamueluth
update writing a hardware component
c98a1c4
@christophfroehlich @mamueluth
Fix RST syntax and some typos (#18)
3d0b364 
* Fix rst syntax and some typos

* Fix rst syntax and small typos

* Fix clang issue
@mamueluth
add changes for chainable controllers (epxport of rerference interfaces)
9710a4c
@mamueluth
rename export_state/command_interface_2 to export_state/commad_interf…
33710bb 
…ace_descriptions
@mamueluth
adapt to new changes and remove some rebase artefacts
726870c
@mamueluth
fix test failures
265f66d
@mamueluth
add interface for warning, error and report
2f45ebf 
 * ddd basic test for error codes setting
 * docs for error and warning signals
@mamueluth mamueluth force-pushed the error_warning_interfaces branch from 7caefee to 2f45ebf Compare July 29, 2024 09:26
@mergify
Copy link

mergify bot commented Jul 29, 2024

This pull request is in conflict. Could you fix it @mamueluth?

@mamueluth mamueluth force-pushed the change_interface_export_variant branch from b6a7819 to 1cea7f2 Compare August 14, 2024 09:05
@github-actions
Copy link

github-actions bot commented Apr 11, 2025

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mamueluth @christophfroehlich