Fix Windows compilation error with socket close() function #264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When compiling on Windows 10 using MinGW, the build fails with the following error:
This occurs in
src/dllama-api.cpp
at line 563 and several locations insrc/nn/nn-network.cpp
. The issue prevents Windows users from building bothdllama
anddllama-api
.Root Cause
On Windows, sockets must be closed using
closesocket()
from the Winsock2 library, not the POSIXclose()
function. While the codebase already has conditional includes for Windows vs Unix socket headers, some socket close operations were not wrapped with platform-specific preprocessor directives.Solution
This PR adds platform-specific handling for socket close operations following the same pattern already established elsewhere in the codebase:
#ifdef _WIN32
): Usesclosesocket()
#else
): Usesclose()
Changes
src/dllama-api.cpp
: Fixed client socket close after HTTP request handlingsrc/nn/nn-network.cpp
: Fixed socket close operations in:closeServerSocket()
functionNnNetwork::serve()
methodNnNetwork::~NnNetwork()
destructorTesting
✅ Verified compilation on Linux for both
dllama
anddllama-api
targets - all builds succeed with no errors or warnings.Fixes #234
Related Issues
This follows the same pattern used for Windows compatibility in other parts of the codebase (e.g., lines 73, 194, 208 in
nn-network.cpp
).Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.