Skip to content

Fix Windows compilation error with socket close() function #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
Merged

Fix Windows compilation error with socket close() function #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e60d1b8
Initial plan
Copilot Oct 5, 2025
6e76632
Fix Windows socket close() compilation errors
Copilot Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/dllama-api.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,11 @@ static void server(AppInferenceContext *context) {
HttpRequest request = HttpRequest::read(clientSocket);
printf("🔷 %s %s\n", request.getMethod().c_str(), request.path.c_str());
Router::resolve(request, routes);
#ifdef _WIN32
closesocket(clientSocket);
#else
close(clientSocket);
#endif
} catch (NnReadNetworkException& ex) {
printf("Read socket error: %d %s\n", ex.code, ex.message);
} catch (NnWriteNetworkException& ex) {
Expand Down
12 changes: 12 additions & 0 deletions src/nn/nn-network.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,11 @@ int createServerSocket(int port) {

void closeServerSocket(int serverSocket) {
shutdown(serverSocket, 2);
#ifdef _WIN32
closesocket(serverSocket);
#else
close(serverSocket);
#endif
}

int acceptSocket(int serverSocket) {
Expand Down Expand Up @@ -313,7 +317,11 @@ std::unique_ptr<NnNetwork> NnNetwork::serve(int port) {
delete[] ports;

shutdown(serverSocket, 2);
#ifdef _WIN32
closesocket(serverSocket);
#else
close(serverSocket);
#endif
printf("⭕ Network is initialized\n");
return std::unique_ptr<NnNetwork>(new NnNetwork(nSockets, sockets));
}
Expand Down Expand Up @@ -359,7 +367,11 @@ NnNetwork::~NnNetwork() {
delete[] recvBytes;
for (NnUint i = 0; i < nSockets; i++) {
shutdown(sockets[i], 2);
#ifdef _WIN32
closesocket(sockets[i]);
#else
close(sockets[i]);
#endif
}
delete[] sockets;
printf("⭕ Network is closed\n");
Expand Down