[OSS-ONLY]Fix dotnet with pgaudit failure in github actions#4301
Merged
tanscorpio7 merged 13 commits intobabelfish-for-postgresql:BABEL_5_X_DEVfrom Dec 15, 2025
Merged
[OSS-ONLY]Fix dotnet with pgaudit failure in github actions#4301tanscorpio7 merged 13 commits intobabelfish-for-postgresql:BABEL_5_X_DEVfrom
tanscorpio7 merged 13 commits intobabelfish-for-postgresql:BABEL_5_X_DEVfrom
Conversation
…local Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Collaborator
Pull Request Test Coverage Report for Build 20241913281Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
tanscorpio7
requested changes
Dec 15, 2025
Comment on lines
88
to
90
| # adding the patch to fix BABEL-4600 to test in Github | ||
| sed -i '1517 s/^ else$/ else if (auditEventStack != NULL)/' pgaudit.c | ||
| sed -i '1532 s/^ else$/ else if (auditEventStack != NULL)/' pgaudit.c | ||
| make install USE_PGXS=1 PG_CONFIG=~/psql/bin/pg_config |
Contributor
There was a problem hiding this comment.
Let's mantain a patch file instead and apply it here, this will avoid future failures like this. You can create a patch file per branch.
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
tanscorpio7
approved these changes
Dec 15, 2025
32e1512
into
babelfish-for-postgresql:BABEL_5_X_DEV
47 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due the community changes(commit) in pgaudit.c file, the path to fix BABEL-4600 become out-dated. Updated the patch which fixes the dotnet test failure when pgaudit extension is installed.
Issues Resolved
[BABEL-6201]
Test Scenarios Covered
Use case based -
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.