Skip to content

[OSS-ONLY]Fix dotnet with pgaudit failure in github actions#4301

Merged
tanscorpio7 merged 13 commits intobabelfish-for-postgresql:BABEL_5_X_DEVfrom
pranavJ23:babel_6201
Dec 15, 2025
Merged

[OSS-ONLY]Fix dotnet with pgaudit failure in github actions#4301
tanscorpio7 merged 13 commits intobabelfish-for-postgresql:BABEL_5_X_DEVfrom
pranavJ23:babel_6201

Conversation

@pranavJ23
Copy link
Copy Markdown
Contributor

@pranavJ23 pranavJ23 commented Dec 7, 2025

Description

Due the community changes(commit) in pgaudit.c file, the path to fix BABEL-4600 become out-dated. Updated the patch which fixes the dotnet test failure when pgaudit extension is installed.

Issues Resolved

[BABEL-6201]

Test Scenarios Covered

  • Use case based -

  • Boundary conditions -

  • Arbitrary inputs -

  • Negative test cases -

  • Minor version upgrade tests -

  • Major version upgrade tests -

  • Performance tests -

  • Tooling impact -

  • Client tests -

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…local

Signed-off-by: pranav jain <pranav23iitd@gmail.com>
@pranavJ23 pranavJ23 changed the title running dotnet with pgaudit to analyse failure [WIP]running dotnet with pgaudit to analyse failure Dec 7, 2025
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Dec 7, 2025

Pull Request Test Coverage Report for Build 20241913281

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 39 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.07%) to 76.817%

Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_common/src/geo.c 6 95.08%
contrib/babelfishpg_common/src/geo_parser.y 7 90.79%
contrib/babelfishpg_common/src/spatialtypes.c 26 96.99%
Totals Coverage Status
Change from base Build 19904444262: 0.07%
Covered Lines: 52228
Relevant Lines: 67990

💛 - Coveralls

Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
@pranavJ23 pranavJ23 changed the title [WIP]running dotnet with pgaudit to analyse failure [OSS-ONLY]running dotnet with pgaudit to analyse failure Dec 14, 2025
Comment on lines 88 to 90
# adding the patch to fix BABEL-4600 to test in Github
sed -i '1517 s/^ else$/ else if (auditEventStack != NULL)/' pgaudit.c
sed -i '1532 s/^ else$/ else if (auditEventStack != NULL)/' pgaudit.c
make install USE_PGXS=1 PG_CONFIG=~/psql/bin/pg_config
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's mantain a patch file instead and apply it here, this will avoid future failures like this. You can create a patch file per branch.

Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
Signed-off-by: pranav jain <pranav23iitd@gmail.com>
@tanscorpio7 tanscorpio7 merged commit 32e1512 into babelfish-for-postgresql:BABEL_5_X_DEV Dec 15, 2025
47 checks passed
@pranavJ23 pranavJ23 changed the title [OSS-ONLY]running dotnet with pgaudit to analyse failure [OSS-ONLY]Fix dotnet with pgaudit failure in github actions Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants